editor.quicksSuggestions.other defaults off

Author: fstasi

arduino-ide-extension/src/browser/settings.tsx

@@ -24,6 +24,7 @@ export interface Settings extends Index {
     editorFontSize: number; // `editor.fontSize`
     themeId: string; // `workbench.colorTheme`
     autoSave: 'on' | 'off'; // `editor.autoSave`
+    quickSuggestions: Record<'other'|'comments'|'strings', boolean>; // `editor.quickSuggestions`
 
     autoScaleInterface: boolean; // `arduino.window.autoScale`
     interfaceScale: number; // `arduino.window.zoomLevel` https://github.com/eclipse-theia/theia/issues/8751
@@ -84,6 +85,7 @@ export class SettingsService {
             editorFontSize,
             themeId,
             autoSave,
+            quickSuggestions,
             autoScaleInterface,
             interfaceScale,
             // checkForUpdates,
@@ -97,6 +99,11 @@ export class SettingsService {
             this.preferenceService.get<number>('editor.fontSize', 12),
             this.preferenceService.get<string>('workbench.colorTheme', 'arduino-theme'),
             this.preferenceService.get<'on' | 'off'>('editor.autoSave', 'on'),
+            this.preferenceService.get<object>('editor.quickSuggestion', {
+              'other': false,
+              'comments': false,
+              'strings': false
+            }),
             this.preferenceService.get<boolean>('arduino.window.autoScale', true),
             this.preferenceService.get<number>('arduino.window.zoomLevel', 0),
             // this.preferenceService.get<string>('arduino.ide.autoUpdate', true),
@@ -113,6 +120,7 @@ export class SettingsService {
             editorFontSize,
             themeId,
             autoSave,
+            quickSuggestions,
             autoScaleInterface,
             interfaceScale,
             // checkForUpdates,
@@ -175,6 +183,7 @@ export class SettingsService {
             editorFontSize,
             themeId,
             autoSave,
+            quickSuggestions,
             autoScaleInterface,
             interfaceScale,
             // checkForUpdates,
@@ -199,6 +208,7 @@ export class SettingsService {
             this.preferenceService.set('editor.fontSize', editorFontSize, PreferenceScope.User),
             this.preferenceService.set('workbench.colorTheme', themeId, PreferenceScope.User),
             this.preferenceService.set('editor.autoSave', autoSave, PreferenceScope.User),
+            this.preferenceService.set('editor.quickSuggestions', quickSuggestions, PreferenceScope.User),
             this.preferenceService.set('arduino.window.autoScale', autoScaleInterface, PreferenceScope.User),
             this.preferenceService.set('arduino.window.zoomLevel', interfaceScale, PreferenceScope.User),
             // this.preferenceService.set('arduino.ide.autoUpdate', checkForUpdates, PreferenceScope.User),
@@ -360,6 +370,13 @@ export class SettingsComponent extends React.Component<SettingsComponent.Props,
                     onChange={this.autoSaveDidChange} />
                 Auto save
             </label>
+            <label className='flex-line'>
+                <input
+                    type='checkbox'
+                    checked={this.state.quickSuggestions.other === true}
+                    onChange={this.quickSuggestionsOtherDidChange} />
+                Editor Quick Suggestions
+            </label>
             <label className='flex-line'>
                 <input
                     type='checkbox'
@@ -551,6 +568,21 @@ export class SettingsComponent extends React.Component<SettingsComponent.Props,
         this.setState({ autoSave: event.target.checked ? 'on' : 'off' });
     };
 
+    protected quickSuggestionsOtherDidChange = (event: React.ChangeEvent<HTMLInputElement>) => {
+      
+      // need to persist react events through lifecycle https://reactjs.org/docs/events.html#event-pooling
+      const newVal = event.target.checked ? true : false
+      
+      this.setState(prevState => {
+        return {
+          quickSuggestions: {
+            ...prevState.quickSuggestions,
+            other: newVal
+          }
+        }
+      });
+    };
+
     protected themeDidChange = (event: React.ChangeEvent<HTMLSelectElement>) => {
         const { selectedIndex } = event.target.options;
         const theme = ThemeService.get().getThemes()[selectedIndex];

arduino-ide-extension/src/browser/style/settings-dialog.css

@@ -4,7 +4,7 @@
 
 .arduino-settings-dialog .content {
     padding: 5px;
-    height: 270px;
+    height: 300px;
 }
 
 .arduino-settings-dialog .flex-line {

arduino-ide-extension/src/browser/toolbar/arduino-toolbar-contribution.ts

@@ -1,9 +1,9 @@
-import { FrontendApplicationContribution, FrontendApplication, Widget, Message } from "@theia/core/lib/browser";
-import { injectable, inject } from "inversify";
-import { ArduinoToolbar } from "./arduino-toolbar";
-import { TabBarToolbarRegistry } from "@theia/core/lib/browser/shell/tab-bar-toolbar";
-import { CommandRegistry } from "@theia/core";
-import { LabelParser } from "@theia/core/lib/browser/label-parser";
+import { FrontendApplicationContribution, FrontendApplication, Widget, Message } from '@theia/core/lib/browser';
+import { injectable, inject } from 'inversify';
+import { ArduinoToolbar } from './arduino-toolbar';
+import { TabBarToolbarRegistry } from '@theia/core/lib/browser/shell/tab-bar-toolbar';
+import { CommandRegistry } from '@theia/core';
+import { LabelParser } from '@theia/core/lib/browser/label-parser';
 
 export class ArduinoToolbarContainer extends Widget {
 

arduino-ide-extension/src/electron-main/splash/splash-screen.ts

@@ -28,7 +28,7 @@ SOFTWARE.
  */
 
 import { Event } from '@theia/core/lib/common/event';
-import { BrowserWindow } from "electron";
+import { BrowserWindow } from 'electron';
 
 /**
  * When splashscreen was shown.
@@ -126,11 +126,11 @@ export const initSplashScreen = (config: Config, onCloseRequested?: Event<void>)
     const window = new BrowserWindow(xConfig.windowOpts);
     splashScreen = new BrowserWindow(xConfig.splashScreenOpts);
     splashScreen.loadURL(`file://${xConfig.templateUrl}`);
-    xConfig.closeWindow && splashScreen.on("close", () => {
+    xConfig.closeWindow && splashScreen.on('close', () => {
         done || window.close();
     });
     // Splashscreen is fully loaded and ready to view.
-    splashScreen.webContents.on("did-finish-load", () => {
+    splashScreen.webContents.on('did-finish-load', () => {
         splashScreenReady = true;
         showSplash();
     });

arduino-ide-extension/tslint.json

@@ -15,6 +15,7 @@
       "check-else",
       "check-whitespace"
     ],
+    "quotemark": [true, "single", "avoid-escape"],
     "radix": true,
     "trailing-comma": [false],
     "triple-equals": [true, "allow-null-check"],
@@ -34,4 +35,4 @@
       "check-type"
     ]
   }
-}
+}

browser-app/package.json

@@ -37,7 +37,12 @@
           "editor.autoSave": "on",
           "editor.minimap.enabled": false,
           "editor.tabSize": 2,
-          "editor.scrollBeyondLastLine": false
+          "editor.scrollBeyondLastLine": false,
+          "editor.quickSuggestions": {
+            "other": false,
+            "comments": false,
+            "strings": false
+          }
         }
       }
     },

electron-app/package.json

@@ -40,7 +40,12 @@
           "editor.autoSave": "on",
           "editor.minimap.enabled": false,
           "editor.tabSize": 2,
-          "editor.scrollBeyondLastLine": false
+          "editor.scrollBeyondLastLine": false,
+          "editor.quickSuggestions": {
+            "other": false,
+            "comments": false,
+            "strings": false
+          }
         }
       }
     },