From 5d6010794913196c30f6e3ce5127235ec067c72e Mon Sep 17 00:00:00 2001 From: Umberto Baldi Date: Tue, 7 Nov 2023 14:37:32 +0100 Subject: [PATCH 1/2] remove `--keepParent`, it's breaking the autoupdate bundle. This flag was introduced by mistake, inside gon only `-c -k` were used https://github.com/mitchellh/gon/blob/2d4f161ccecd1aae878f4416d5ccd622b1b01fdb/package/zip/zip.go#L59 --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1c3c282b8..41c44a886 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -295,7 +295,7 @@ jobs: run: gon -log-level=debug -log-json "${{ env.GON_CONFIG_PATH }}" - name: Zip output app bundle - run: ditto -c -k --keepParent ArduinoCreateAgent.app/ ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip + run: ditto -c -k ArduinoCreateAgent.app/ ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip - name: Remove gon used for code signing run: | From be34cd0a3378271cceb444cebf5dd8d3b8c6c322 Mon Sep 17 00:00:00 2001 From: Umberto Baldi Date: Tue, 7 Nov 2023 14:37:57 +0100 Subject: [PATCH 2/2] Revert "remove top level dir it's already there thanks to `ditto --keepParent" This reverts commit 134d25068c8e8fb980e163761466cc29fe8ec904. --- .github/workflows/release.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 41c44a886..d0cf50d50 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -455,10 +455,13 @@ jobs: uses: actions/download-artifact@v3 with: name: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized + path: ArduinoCreateAgent.app - name: unzip artifact + working-directory: ArduinoCreateAgent.app run: | unzip ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip + rm ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip - name: Install create-dmg run: brew install create-dmg