Skip to content

Warnings for .pde file are emitted even if the current dir is not a sketch #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
cmaglie opened this issue Oct 24, 2023 · 0 comments · Fixed by #2490
Closed
3 tasks done

Warnings for .pde file are emitted even if the current dir is not a sketch #2384

cmaglie opened this issue Oct 24, 2023 · 0 comments · Fixed by #2490
Assignees
Labels
topic: CLI Related to the command line interface type: imperfection Perceived defect in any part of project

Comments

@cmaglie
Copy link
Member

cmaglie commented Oct 24, 2023

Describe the problem

The warning Sketches with .pde extension are deprecated, please rename the following files to .ino is emitted even if the current directory is not a sketch. This means that a scan of the subdirectories is performed even if it is useless.

To reproduce

For example if you run arduino-cli compile in the git root folder of the arduino-cli repository:

~/Workspace/arduino-cli ⎇  master $ arduino-cli compile
Sketches with .pde extension are deprecated, please rename the following files to .ino:
 - /home/cmaglie/Workspace/arduino-cli/arduino/builder/testdata/TestLoadSketchFolder/old.pde
 - /home/cmaglie/Workspace/arduino-cli/arduino/builder/testdata/TestLoadSketchFolderBothInoAndPde/TestLoadSketchFolderBothInoAndPde.pde
 - /home/cmaglie/Workspace/arduino-cli/arduino/builder/testdata/TestLoadSketchFolderBothInoAndPde/old.pde
 - /home/cmaglie/Workspace/arduino-cli/arduino/builder/testdata/TestLoadSketchFolderPde/TestLoadSketchFolderPde.pde
 - /home/cmaglie/Workspace/arduino-cli/arduino/builder/testdata/TestLoadSketchFolderPde/old.pde
 - /home/cmaglie/Workspace/arduino-cli/arduino/builder/testdata/TestLoadSketchFolderSymlinkSrc/old.pde
 - /home/cmaglie/Workspace/arduino-cli/arduino/libraries/testdata/TestLibExamples/examples/MultipleFiles/MultipleFiles.pde
 - /home/cmaglie/Workspace/arduino-cli/arduino/sketch/testdata/SketchBothInoAndPde/SketchBothInoAndPde.pde
 - /home/cmaglie/Workspace/arduino-cli/arduino/sketch/testdata/SketchMultipleMainFiles/SketchMultipleMainFiles.pde
 - /home/cmaglie/Workspace/arduino-cli/arduino/sketch/testdata/SketchPde/SketchPde.pde
 - /home/cmaglie/Workspace/arduino-cli/arduino/sketch/testdata/SketchSymlinkSrc/old.pde
 - /home/cmaglie/Workspace/arduino-cli/internal/integrationtest/compile_4/testdata/SketchWithMergedSketchAndBootloader/old.pde
 - /home/cmaglie/Workspace/arduino-cli/internal/integrationtest/testdata/sketch_multiple_main_files/sketch_multiple_main_files.pde
 - /home/cmaglie/Workspace/arduino-cli/internal/integrationtest/testdata/sketch_pde_main_file/sketch_pde_main_file.pde
 - /home/cmaglie/Workspace/arduino-cli/internal/integrationtest/testdata/sketch_simple/old.pde
Can't open sketch: main file missing from sketch: /home/cmaglie/Workspace/arduino-cli/arduino-cli.ino
~/Workspace/arduino-cli ⎇  master $ 

Expected behavior

~/Workspace/arduino-cli ⎇  master $ arduino-cli compile
Can't open sketch: main file missing from sketch: /home/cmaglie/Workspace/arduino-cli/arduino-cli.ino
~/Workspace/arduino-cli ⎇  master $

Arduino CLI version

nightly

Operating system

N/A

Operating system version

N/A

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the nightly build
  • My report contains all necessary details
@cmaglie cmaglie added type: imperfection Perceived defect in any part of project topic: CLI Related to the command line interface labels Oct 24, 2023
@umbynos umbynos added this to the Arduino CLI v0.36.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface type: imperfection Perceived defect in any part of project
Projects
None yet
2 participants