Make depends in index check support spaces in library names

Author: per1234

check/checkfunctions/library.go

@@ -841,12 +841,14 @@ func LibraryPropertiesDependsFieldNotInIndex() (result checkresult.Type, output
 		return checkresult.NotRun, "Field not present"
 	}
 
-	dependencies, err := properties.SplitQuotedString(depends, "", false)
-	if err != nil {
-		panic(err)
-	}
+	dependencies := strings.Split(depends, ",")
+
 	dependenciesNotInIndex := []string{}
 	for _, dependency := range dependencies {
+		dependency = strings.TrimSpace(dependency)
+		if dependency == "" {
+			continue
+		}
 		logrus.Tracef("Checking if dependency %s is in index.", dependency)
 		if !nameInLibraryManagerIndex(dependency) {
 			dependenciesNotInIndex = append(dependenciesNotInIndex, dependency)

check/checkfunctions/library_test.go

@@ -309,6 +309,7 @@ func TestLibraryPropertiesDependsFieldNotInIndex(t *testing.T) {
 		{"Unable to load", "InvalidLibraryProperties", checkresult.NotRun, ""},
 		{"Dependency not in index", "DependsNotIndexed", checkresult.Fail, "^NotIndexed$"},
 		{"Dependency in index", "DependsIndexed", checkresult.Pass, ""},
+		{"Depends field empty", "DependsEmpty", checkresult.Pass, ""},
 		{"No depends", "NoDepends", checkresult.NotRun, ""},
 	}
 

check/checkfunctions/testdata/libraries/DependsEmpty/library.properties

@@ -0,0 +1,10 @@
+name=DependsEmpty
+version=1.0.0
+author=Cristian Maglie <[email protected]>, Pippo Pluto <[email protected]>
+maintainer=Cristian Maglie <[email protected]>
+sentence=A library that makes coding a web server a breeze.
+paragraph=Supports HTTP1.1 and you can do GET and POST.
+category=Communication
+url=http://example.com/
+architectures=avr
+depends=

check/checkfunctions/testdata/libraries/DependsEmpty/src/DependsEmpty.h

@@ -7,4 +7,4 @@ paragraph=Supports HTTP1.1 and you can do GET and POST.
 category=Communication
 url=http://example.com/
 architectures=avr
-depends=Servo
+depends=Servo, , Adafruit NeoPixel