Always use 'installed' version if available

Author: cmaglie

commands/lib/resolve_deps.go

@@ -25,6 +25,7 @@ import (
 	"github.com/arduino/arduino-cli/arduino/libraries/librariesindex"
 	"github.com/arduino/arduino-cli/commands/internal/instances"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
+	semver "go.bug.st/relaxed-semver"
 )
 
 // LibraryResolveDependencies FIXMEDOC
@@ -80,14 +81,19 @@ func LibraryResolveDependencies(ctx context.Context, req *rpc.LibraryResolveDepe
 	res := []*rpc.LibraryDependencyStatus{}
 	for _, dep := range deps {
 		// ...and add information on currently installed versions of the libraries
-		installed := ""
+		var installed *semver.Version
+		required := dep.GetVersion()
 		if installedLib, has := installedLibs[dep.GetName()]; has {
-			installed = installedLib.Version.String()
+			installed = installedLib.Version
+			if installed != nil && required != nil && installed.Equal(required) {
+				// avoid situations like installed=0.53 and required=0.53.0
+				required = installed
+			}
 		}
 		res = append(res, &rpc.LibraryDependencyStatus{
 			Name:             dep.GetName(),
-			VersionRequired:  dep.GetVersion().String(),
-			VersionInstalled: installed,
+			VersionRequired:  required.String(),
+			VersionInstalled: installed.String(),
 		})
 	}
 	sort.Slice(res, func(i, j int) bool {

internal/integrationtest/lib/lib_test.go

@@ -1693,6 +1693,7 @@ func TestDependencyResolverNoOverwrite(t *testing.T) {
 		]
 	}`)
 	require.NotEqual(t, outjson.Query("dependencies[0].version_required").String(), `"2.53.0"`)
+	require.NotEqual(t, outjson.Query("dependencies[0].version_required").String(), `"2.53"`)
 
 	out, _, err = cli.Run("lib", "deps", "[email protected]", "--no-overwrite", "--format", "json")
 	require.NoError(t, err)
@@ -1701,7 +1702,7 @@ func TestDependencyResolverNoOverwrite(t *testing.T) {
 		"dependencies": [
 			{
 				"name": "Bounce2",
-				"version_required": "2.53.0",
+				"version_required": "2.53",
 				"version_installed": "2.53"
 			},
 			{