Skip to content

Commit 67fc33f

Browse files
authored
Fix regression: report size delta size on PR. (#20)
The necessary steps have in fact been documented here: https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#workflow-triggered-by-pull_request-event but I have overlooked them when I fixed the upload issue. With this PR the size deltas are - once again - reported within the PR.
1 parent fd4e10f commit 67fc33f

File tree

3 files changed

+24
-28
lines changed

3 files changed

+24
-28
lines changed

.github/workflows/compile-examples.yml

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,15 @@ on:
2020
workflow_dispatch:
2121
repository_dispatch:
2222

23+
env:
24+
# It's convenient to set variables for values used multiple times in the workflow.
25+
SKETCHES_REPORTS_PATH: sketches-reports
26+
2327
jobs:
24-
build:
28+
compile:
2529
name: ${{ matrix.board.fqbn }}
2630
runs-on: ubuntu-latest
2731

28-
env:
29-
SKETCHES_REPORTS_PATH: sketches-reports
30-
3132
strategy:
3233
fail-fast: false
3334

@@ -140,3 +141,21 @@ jobs:
140141
if-no-files-found: error
141142
path: ${{ env.SKETCHES_REPORTS_PATH }}
142143
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
144+
145+
# When using a matrix to compile for multiple boards, it's necessary to use a separate job for the deltas report
146+
report:
147+
needs: compile # Wait for the compile job to finish to get the data for the report
148+
if: github.event_name == 'pull_request' # Only run the job when the workflow is triggered by a pull request
149+
runs-on: ubuntu-latest
150+
151+
steps:
152+
# This step is needed to get the size data produced by the compile jobs
153+
- name: Download sketches reports artifacts
154+
uses: actions/download-artifact@v4
155+
with:
156+
# All workflow artifacts will be downloaded to this location.
157+
path: ${{ env.SKETCHES_REPORTS_PATH }}
158+
159+
- uses: arduino/report-size-deltas@v1
160+
with:
161+
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}

.github/workflows/report-size-deltas.yml

Lines changed: 0 additions & 24 deletions
This file was deleted.

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
.idea/

0 commit comments

Comments
 (0)