Skip to content

Commit 47e81e5

Browse files
ian-abbotttorvalds
authored andcommitted
linux/bug.h: correct "space required before that '-'"
Correct these checkpatch.pl errors: |ERROR: space required before that '-' (ctx:OxO) |#37: FILE: include/linux/bug.h:37: |+#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); })) |ERROR: space required before that '-' (ctx:OxO) |#38: FILE: include/linux/bug.h:38: |+#define BUILD_BUG_ON_NULL(e) ((void *)sizeof(struct { int:-!!(e); })) I decided to wrap the bitfield expressions that begin with minus signs in parentheses rather than insert spaces before the minus signs. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Ian Abbott <[email protected]> Acked-by: Michal Nazarewicz <[email protected]> Cc: Kees Cook <[email protected]> Cc: Steven Rostedt <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Jakub Kicinski <[email protected]> Cc: Rasmus Villemoes <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 8cdd7cc commit 47e81e5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/linux/bug.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ struct pt_regs;
3636
* e.g. in a structure initializer (or where-ever else comma expressions
3737
* aren't permitted).
3838
*/
39-
#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
40-
#define BUILD_BUG_ON_NULL(e) ((void *)sizeof(struct { int:-!!(e); }))
39+
#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); }))
40+
#define BUILD_BUG_ON_NULL(e) ((void *)sizeof(struct { int:(-!!(e)); }))
4141

4242
/*
4343
* BUILD_BUG_ON_INVALID() permits the compiler to check the validity of the

0 commit comments

Comments
 (0)