From 2d075988382875ccfd3c4921805821f8c5e87492 Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Wed, 29 Jan 2020 08:31:10 +0100 Subject: [PATCH 1/3] revert: "test(@angular-devkit/build-angular): add `skipLibCheck` to tests workspace tsconfig" This reverts commit 3ae1eb6e2d80d424aee9fb966787d28843f5c2f4. --- .../build_angular/hello-world-app-ve/tsconfig.json | 1 - tests/angular_devkit/build_angular/hello-world-app/tsconfig.json | 1 - .../angular_devkit/build_ng_packagr/ng-packaged-ve/tsconfig.json | 1 - tests/angular_devkit/build_ng_packagr/ng-packaged/tsconfig.json | 1 - 4 files changed, 4 deletions(-) diff --git a/tests/angular_devkit/build_angular/hello-world-app-ve/tsconfig.json b/tests/angular_devkit/build_angular/hello-world-app-ve/tsconfig.json index 019f3395ce0c..641ccb244858 100644 --- a/tests/angular_devkit/build_angular/hello-world-app-ve/tsconfig.json +++ b/tests/angular_devkit/build_angular/hello-world-app-ve/tsconfig.json @@ -5,7 +5,6 @@ "outDir": "./dist/out-tsc", "sourceMap": true, "declaration": false, - "skipLibCheck": true, "moduleResolution": "node", "emitDecoratorMetadata": true, "experimentalDecorators": true, diff --git a/tests/angular_devkit/build_angular/hello-world-app/tsconfig.json b/tests/angular_devkit/build_angular/hello-world-app/tsconfig.json index 440dd0d48ef8..0b2d4a18fce3 100644 --- a/tests/angular_devkit/build_angular/hello-world-app/tsconfig.json +++ b/tests/angular_devkit/build_angular/hello-world-app/tsconfig.json @@ -5,7 +5,6 @@ "outDir": "./dist/out-tsc", "sourceMap": true, "declaration": false, - "skipLibCheck": true, "moduleResolution": "node", "emitDecoratorMetadata": true, "experimentalDecorators": true, diff --git a/tests/angular_devkit/build_ng_packagr/ng-packaged-ve/tsconfig.json b/tests/angular_devkit/build_ng_packagr/ng-packaged-ve/tsconfig.json index 44a248786405..cc264e55b22d 100644 --- a/tests/angular_devkit/build_ng_packagr/ng-packaged-ve/tsconfig.json +++ b/tests/angular_devkit/build_ng_packagr/ng-packaged-ve/tsconfig.json @@ -5,7 +5,6 @@ "outDir": "./dist/out-tsc", "sourceMap": true, "declaration": false, - "skipLibCheck": true, "moduleResolution": "node", "emitDecoratorMetadata": true, "experimentalDecorators": true, diff --git a/tests/angular_devkit/build_ng_packagr/ng-packaged/tsconfig.json b/tests/angular_devkit/build_ng_packagr/ng-packaged/tsconfig.json index a7adf91b1716..40def946d5f4 100644 --- a/tests/angular_devkit/build_ng_packagr/ng-packaged/tsconfig.json +++ b/tests/angular_devkit/build_ng_packagr/ng-packaged/tsconfig.json @@ -5,7 +5,6 @@ "outDir": "./dist/out-tsc", "sourceMap": true, "declaration": false, - "skipLibCheck": true, "moduleResolution": "node", "emitDecoratorMetadata": true, "experimentalDecorators": true, From e39edb9e019f909e4d1715cab9960c476429ca7c Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Wed, 29 Jan 2020 08:31:47 +0100 Subject: [PATCH 2/3] revert: "fix(@schematics/angular): add `skipLibCheck` to workspace tsconfig" This reverts commit a8c60cb8b976d50c898607a5a5bf4fe84f0b2bfb. Closes: #16696 --- .../schematics/angular/workspace/files/tsconfig.json.template | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/schematics/angular/workspace/files/tsconfig.json.template b/packages/schematics/angular/workspace/files/tsconfig.json.template index b1ce7545b64c..9eb43d31920f 100644 --- a/packages/schematics/angular/workspace/files/tsconfig.json.template +++ b/packages/schematics/angular/workspace/files/tsconfig.json.template @@ -8,7 +8,6 @@ "noImplicitThis": true, "noFallthroughCasesInSwitch": true, "strictNullChecks": true,<% } %> - "skipLibCheck": true, "sourceMap": true, "declaration": false, "downlevelIteration": true, From 9e4ff3e3fca11840ed72eb65a2eea4e6c01ea16c Mon Sep 17 00:00:00 2001 From: Alan Agius Date: Wed, 29 Jan 2020 08:33:29 +0100 Subject: [PATCH 3/3] revert: "test: add e2e test to test disabled skipLibCheck" This reverts commit aadf779e3a4f864a0a82f02aee592c061f880ed5. --- tests/legacy-cli/e2e/tests/build/skip-lib-check.ts | 11 ----------- 1 file changed, 11 deletions(-) delete mode 100644 tests/legacy-cli/e2e/tests/build/skip-lib-check.ts diff --git a/tests/legacy-cli/e2e/tests/build/skip-lib-check.ts b/tests/legacy-cli/e2e/tests/build/skip-lib-check.ts deleted file mode 100644 index 79c2a753e170..000000000000 --- a/tests/legacy-cli/e2e/tests/build/skip-lib-check.ts +++ /dev/null @@ -1,11 +0,0 @@ -import { ng } from '../../utils/process'; -import { createProject, updateTsConfig } from '../../utils/project'; - - -export default async function() { - await createProject('strict-workspace-test-project', '--strict'); - await updateTsConfig(json => { - json['compilerOptions']['skipLibCheck'] = false; - }); - await ng('build'); -}