build: fix type errors

Author: alumni

package.json

@@ -85,6 +85,7 @@
     "test": "npm run compile && npm run test:fast --",
     "test:ci": "mocha --bail",
     "test:fast": "mocha",
+    "typecheck": "tsc --noEmit",
     "watch": "tsc --watch"
   },
   "dependencies": {

src/driver/aurora-postgres/AuroraPostgresDriver.ts

@@ -10,7 +10,7 @@ import { ApplyValueTransformers } from "../../util/ApplyValueTransformers"
 import { DriverUtils } from "../DriverUtils"
 
 abstract class PostgresWrapper extends PostgresDriver {
-    options: any
+    declare options: any
 
     abstract createQueryRunner(mode: ReplicationMode): any
 }

src/driver/aurora-postgres/AuroraPostgresQueryRunner.ts

@@ -10,7 +10,7 @@ import { Table } from "../../schema-builder/table/Table"
 import { TypeORMError } from "../../error"
 
 class PostgresQueryRunnerWrapper extends PostgresQueryRunner {
-    driver: any
+    declare driver: any
 
     constructor(driver: any, mode: ReplicationMode) {
         super(driver, mode)
@@ -31,19 +31,10 @@ export class AuroraPostgresQueryRunner
     /**
      * Database driver used by connection.
      */
-    driver: AuroraPostgresDriver
+    declare driver: AuroraPostgresDriver
 
     protected client: any
 
-    // -------------------------------------------------------------------------
-    // Protected Properties
-    // -------------------------------------------------------------------------
-
-    /**
-     * Promise used to obtain a database connection for a first time.
-     */
-    protected databaseConnectionPromise: Promise<any>
-
     // -------------------------------------------------------------------------
     // Constructor
     // -------------------------------------------------------------------------

src/driver/better-sqlite3/BetterSqlite3Driver.ts

@@ -24,11 +24,6 @@ export class BetterSqlite3Driver extends AbstractSqliteDriver {
      */
     options: BetterSqlite3ConnectionOptions
 
-    /**
-     * SQLite underlying library.
-     */
-    sqlite: any
-
     // -------------------------------------------------------------------------
     // Constructor
     // -------------------------------------------------------------------------

src/driver/capacitor/CapacitorDriver.ts

@@ -8,7 +8,7 @@ import { ReplicationMode } from "../types/ReplicationMode"
 
 export class CapacitorDriver extends AbstractSqliteDriver {
     driver: any
-    options: CapacitorConnectionOptions
+    declare options: CapacitorConnectionOptions
 
     // -------------------------------------------------------------------------
     // Constructor

src/driver/cordova/CordovaDriver.ts

@@ -14,7 +14,7 @@ interface Window {
 declare let window: Window
 
 export class CordovaDriver extends AbstractSqliteDriver {
-    options: CordovaConnectionOptions
+    declare options: CordovaConnectionOptions
 
     transactionSupport = "none" as const
 

src/driver/expo/ExpoDriver.ts

@@ -5,7 +5,7 @@ import { QueryRunner } from "../../query-runner/QueryRunner"
 import { DataSource } from "../../data-source/DataSource"
 
 export class ExpoDriver extends AbstractSqliteDriver {
-    options: ExpoConnectionOptions
+    declare options: ExpoConnectionOptions
 
     constructor(connection: DataSource) {
         super(connection)

src/driver/expo/legacy/ExpoLegacyDriver.ts

@@ -6,7 +6,7 @@ import { DataSource } from "../../../data-source/DataSource"
 import { ReplicationMode } from "../../types/ReplicationMode"
 
 export class ExpoLegacyDriver extends AbstractSqliteDriver {
-    options: ExpoConnectionOptions
+    declare options: ExpoConnectionOptions
 
     // -------------------------------------------------------------------------
     // Constructor

src/driver/sqlite/SqliteDriver.ts

@@ -24,11 +24,6 @@ export class SqliteDriver extends AbstractSqliteDriver {
      */
     options: SqliteConnectionOptions
 
-    /**
-     * SQLite underlying library.
-     */
-    sqlite: any
-
     // -------------------------------------------------------------------------
     // Constructor
     // -------------------------------------------------------------------------

src/driver/sqljs/SqljsDriver.ts

@@ -21,7 +21,7 @@ declare let window: Window
 
 export class SqljsDriver extends AbstractSqliteDriver {
     // The driver specific options.
-    options: SqljsConnectionOptions
+    declare options: SqljsConnectionOptions
 
     // -------------------------------------------------------------------------
     // Constructor

src/repository/MongoRepository.ts

@@ -60,7 +60,7 @@ export class MongoRepository<
     /**
      * Entity Manager used by this repository.
      */
-    readonly manager: MongoEntityManager
+    declare readonly manager: MongoEntityManager
 
     // -------------------------------------------------------------------------
     // Overridden Methods

test/functional/query-runner/stream.ts

@@ -46,13 +46,13 @@ describe("query runner > stream", () => {
                 const readStream = await queryRunner.stream(query)
 
                 if (!(connection.driver.options.type === "spanner"))
-                    await new Promise((ok) => readStream.once("readable", ok))
+                    await new Promise<void>((ok) => readStream.once("readable", ok))
 
                 const data: any[] = []
 
                 readStream.on("data", (row) => data.push(row))
 
-                await new Promise((ok) => readStream.once("end", ok))
+                await new Promise<void>((ok) => readStream.once("end", ok))
 
                 expect(data).to.have.length(4)
 

tsconfig.json

@@ -18,6 +18,7 @@
         "strictFunctionTypes": false,
         "strictPropertyInitialization": false,
         "stripInternal": true,
+        "useDefineForClassFields": false,
         "useUnknownInCatchVariables": false
     },
     "include": [