Skip to content

confusion_matrix, roc_curve: Use standardized nullable type handling #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tamargrey opened this issue Feb 17, 2023 · 0 comments · Fixed by #4072
Closed

confusion_matrix, roc_curve: Use standardized nullable type handling #4019

tamargrey opened this issue Feb 17, 2023 · 0 comments · Fixed by #4072
Assignees

Comments

@tamargrey
Copy link
Contributor

Currently, we handle nullable types for the confusion_matrix and roc_curve with the _convert_ww_series_to_np_array util, which works around the inability of Series.to_numpy to recognize the pandas nullable dtypes, resulting in numpy data with the object dtype, which causes errors down the line.

We should move _convert_ww_series_to_np_array to the nullable type handling utils file and rename it to make it celar it has to do with nullable type handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant