Skip to content

Sleep/Savestates/Memories support? #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zkat opened this issue Dec 9, 2022 · 19 comments
Open

Sleep/Savestates/Memories support? #59

zkat opened this issue Dec 9, 2022 · 19 comments

Comments

@zkat
Copy link

zkat commented Dec 9, 2022

When I try to do sleep mode on my Analogue Pocket, it says it's not supported by this cartridge, and offers to power off instead. Is it possible to add support for sleep?


agg23 EDIT: I am waiting on the paulb-nl savestates fork to become more stable before I look at integrating it. A good measure is whether it has been added to the main upstream MiSTer core.

@agg23
Copy link
Owner

agg23 commented Dec 9, 2022

Sleep requires save states, which won't be coming to the SNES core. The only third party core currently available with save states is my NES core.

@agg23 agg23 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2022
@zkat
Copy link
Author

zkat commented Dec 9, 2022

Thanks for the response! I was wondering whether this was a save state thing. I've linked this issue (see above) in upstream in hopes that it'll get resolved someday. :)

@DunhamGitHub
Copy link

For me, save states / sleep mode is essential for SNES. Which is why my analogue pocket is collecting dust...

Hoping it will happen due to competition in the market (I see it on the horizon)

@ToniWonKanobi
Copy link

Just wondering why save states won't be coming to this SNES core? Is that the owner doesn't care, or that it's incredibly difficult (more difficult than NES)?

@agg23
Copy link
Owner

agg23 commented Mar 27, 2023

Unlike software emulators, hardware emulators (what we're running on FPGAs) have a significantly higher complexity and must keep track of much more information. Consequently, retroactively adding save states to a core that was not planned around it is a very difficult task (and it's still not easy if you have planned for it).

The person most knowledgeable about the core, srg320_, has previously stated that he has no interest in adding save states. Unless someone very skilled and dedicated decides to do it, it isn't going to happen. It's honestly probably more likely that someone else starts a SNES core from scratch with the idea of including save states.

@ToniWonKanobi
Copy link

Unlike software emulators, hardware emulators (what we're running on FPGAs) have a significantly higher complexity and must keep track of much more information. Consequently, retroactively adding save states to a core that was not planned around it is a very difficult task (and it's still not easy if you have planned for it).

The person most knowledgeable about the core, srg320_, has previously stated that he has no interest in adding save states. Unless someone very skilled and dedicated decides to do it, it isn't going to happen. It's honestly probably more likely that someone else starts a SNES core from scratch with the idea of including save states.

Thanks for the quick reply. I hear what you're saying, but why does the NES core have save states then?

@agg23
Copy link
Owner

agg23 commented Mar 27, 2023

Someone (RobertPeip, and a few people helping him, I think) was dedicated enough to add them. Other than mappers (of which only some are supported for save states), the NES is significantly less complicated than SNES, and the hardware is more understood by more people.

@ToniWonKanobi
Copy link

ToniWonKanobi commented Mar 27, 2023

Fair enough. Really appreciate your responses. Hopefully, my questions didn't come off as frustration pointed in your direction. Thanks, and have a good day sir!

@agg23 agg23 changed the title Sleep Mode support? Sleep/Savestates/Memories support? Apr 6, 2023
@agg23 agg23 mentioned this issue Apr 6, 2023
@zarkone
Copy link

zarkone commented Nov 20, 2024

An update in MISTer land about save states: https://misterfpga.org/viewtopic.php?t=8459

@agg23
Copy link
Owner

agg23 commented Nov 20, 2024

An update in MISTer land about save states: https://misterfpga.org/viewtopic.php?t=8459

It's a very impressive set of changes. I don't believe the source is available at the moment, and even if it was, I don't think it's in a stable enough state to warrant the significant amount of work it would take to get working on the Pocket. I will look into it as it becomes more stable and I have time available though.

@ToniWonKanobi
Copy link

An update in MISTer land about save states: https://misterfpga.org/viewtopic.php?t=8459

It's a very impressive set of changes. I don't believe the source is available at the moment, and even if it was, I don't think it's in a stable enough state to warrant the significant amount of work it would take to get working on the Pocket. I will look into it as it becomes more stable and I have time available though.

Does this mean save states could be coming to the SNES core!? 🙃

@TheJayMann
Copy link

I've not done anything to verify this outside of compare names and dates, but I believe the source code for the latest release in the forum thread (including the update for SA1 support) is available at https://github.com/paulb-nl/SNES_MiSTer/tree/ss_wip.

@agg23
Copy link
Owner

agg23 commented Mar 10, 2025

This person was too lazy to fix it.

That is a very unhelpful comment. I have literally stated that once it's fairly stable I will look into it. As of the moment it breaks in a bunch of scenarios.

I don't think it's in a stable enough state to warrant the significant amount of work it would take to get working on the Pocket. I will look into it as it becomes more stable and I have time available though.

I do this in my free time and am not beholden to your whims on when I should finish this. This takes a very large amount of work and skills that few possess. I would happily accept your PR adding the feature.

@agg23 agg23 reopened this Mar 10, 2025
@zarkone
Copy link

zarkone commented Mar 10, 2025

@agg23 I hope it is rather an exception to get this type of comments.. I also want to assure you that majority of people in the scene understand the complexity and the value of your labor here 💟

tbh, it feels like it might be even impossible to add this thing without complete rewrite of the core. Even with my very limited knowledge, I understand that mister != analog fpga and adding saves to a core which was designed without saves in might might be impossible, because

a very large amount of work and skills that few possess

very sad to see such feedback :( your core is awesome and I'm using it with pleasure 🙏

Thanks for your work!

@zkat
Copy link
Author

zkat commented Mar 10, 2025

I just want to jump in as the OP and echo the above comment. As a pretty active open source maintainer I get how these things go and as excited I am at the prospect of this, I would never want to make someone feel pressured or unappreciated over an issue. I see issues as TODOs or requests, just so we can keep track of things.

And for the record, I did try and look through the code when I felt I had the energy for a bit of a project, but it’s really not the kind of dev in used to doing and honestly I can verify this kind of stuff is terrifyingly complex and low level. That you’ve managed this much is amazing to me. So cheers 💚

@ToniWonKanobi
Copy link

Just wait till someone will make another core that will have savestates/sleep/memories. This person was too lazy to fix it.

Haha. This is pretty harsh, but I do hope the agg23 dude can add save states at some point 🤞

@Skyyblaze
Copy link

I also want to extend my sincere thanks to you agg23, I'm no developer but I understand what a daunting task such a FPGA core must be. Playing SNES on my Pocket became my favorite way to play SNES games thanks to you!

@fox1t
Copy link

fox1t commented Apr 8, 2025

@agg23 thanks for your work. I am an OSS maintainer too and I know how hard it can be sometimes. <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants