exclude in tsconfig.json doesn't work

[slikts]

Adding a directory to the exclude section in tsconfig.json doesn't stop atom-typescript from generating errors about .ts files not being included in the compilation context. The files are supposed to be excluded, so the errors are incorrect.

[basarat]

IGNORE. I WAS CONFUSED AND THOUGHT IT WAS ABOUT #377

For historical reasons:

---

Up for grabs

Implementor guidance

Source code needs to go here : tsconfig.ts

For guidance one can use the work done here. Basically add the excludes to the pseudo filesGlob.

[slikts]

The error isn't affected by excluding the file. errorsForFile() simply checks Project.prototype.includesSourceFile and displays the error if it doesn't. The fix would be to check if the file isn't in an excluded directory before showing the error, but a better fix would be just to remove the error. It's a feature that doesn't play nice with other things, such as using a test runner that compiles TS on its own.

[slikts]

Also, there could be an option to suppress the error. Currently, there is no way to get rid of it other than adding every .ts file to the project. "Helpful" features like this that are implemented in an unintelligent way are quite annoying.

[basarat]

Sorry I thought you meant : #377

On second read this is a duplicate of : #558

@slikts the fact is that we don't support lose .ts files, i.e. files that don't have a tsconfig.json associated. So the error could be replaced with another but it would still be an error. Feel free to continue the discussion here : #558 🌹

[Zorgatone]

My files still get compiled even if excluded 😞

[basarat]

My files still get compiled even if excluded

@Zorgatone if you are using the exclude property, that isn't supported yet : #377

You can use filesGlob in the meantime https://github.com/TypeStrong/atom-typescript/blob/master/docs/tsconfig.md#filesglob