Skip to content

Goto correct definition reference import path #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
teintinu opened this issue Aug 7, 2015 · 2 comments
Closed

Goto correct definition reference import path #520

teintinu opened this issue Aug 7, 2015 · 2 comments

Comments

@teintinu
Copy link

teintinu commented Aug 7, 2015

In above sample, if a point the mouse over something in var a=something() don't show the JSDoc.

I think it's happens because atom-typescript points to import clause. Trying with F12, in first press goes to import clause, in second press goes to correct definition in file2.

I suggest skip import clause and go directly to definition in file2.

file1.ts

import {something} from "file2"
var a=something(); // << mouse hover or F12 here

file2.ts

/** something  text */
function something()
{   
}
@basarat
Copy link
Member

basarat commented Aug 10, 2015

if a point the mouse over something in var a=something() don't show the JSDoc.

Really a language service feature request. Should go to Microsoft/TypeScript 🌹

@basarat
Copy link
Member

basarat commented Aug 10, 2015

For reference, the function we use is getQuickInfoAtPosition :

var info = project.languageService.getQuickInfoAtPosition(query.filePath, query.position);

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants