Skip to content

Commit 1ff05b5

Browse files
committed
Fix file newlines & TS error, normalize permissions comments naming
1 parent 52a4b08 commit 1ff05b5

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

contracts/lib/AddressArrayUtils.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,4 +219,4 @@ library AddressArrayUtils {
219219
require(A.length > 0, "Array length must be > 0");
220220
require(!hasDuplicate(A), "Cannot duplicate addresses");
221221
}
222-
}
222+
}

contracts/lib/PreciseUnitMath.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,4 +194,4 @@ library PreciseUnitMath {
194194
function approximatelyEquals(uint256 a, uint256 b, uint256 range) internal pure returns (bool) {
195195
return a <= b.add(range) && a >= b.sub(range);
196196
}
197-
}
197+
}

contracts/mocks/AddressArrayUtilsMock.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,4 +78,4 @@ contract AddressArrayUtilsMock {
7878
function getStorageArray() external view returns(address[] memory) {
7979
return storageArray;
8080
}
81-
}
81+
}

contracts/mocks/PreciseUnitMathMock.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,4 +85,4 @@ contract PreciseUnitMathMock {
8585
function approximatelyEquals(uint256 a, uint256 b, uint256 range) external pure returns (bool) {
8686
return a.approximatelyEquals(b, range);
8787
}
88-
}
88+
}

contracts/protocol/modules/GeneralIndexModule.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ contract GeneralIndexModule is ModuleBase, ReentrancyGuard {
7878

7979
struct TradePermissionInfo {
8080
bool anyoneTrade; // Boolean indicating if anyone can execute a trade
81-
address[] tradersHistory; // Tracks whitelisted traders to be deleted on module removal
81+
address[] tradersHistory; // Tracks permissioned traders to be deleted on module removal
8282
mapping(address => bool) tradeAllowList; // Mapping indicating which addresses are allowed to execute trade
8383
}
8484

@@ -1043,7 +1043,7 @@ contract GeneralIndexModule is ModuleBase, ReentrancyGuard {
10431043
*/
10441044

10451045
/*
1046-
* Trader must be whitelisted for SetToken
1046+
* Trader must be permissioned for SetToken
10471047
*/
10481048
function _validateOnlyAllowedTrader(ISetToken _setToken) internal view {
10491049
require(_isAllowedTrader(_setToken, msg.sender), "Address not permitted to trade");

test/lib/preciseUnitMath.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ describe("PreciseUnitMath", () => {
474474
subjectRange = ether(2);
475475
});
476476

477-
async function subject(): Promise<[BigNumber]> {
477+
async function subject(): Promise<boolean> {
478478
return mathMock.approximatelyEquals(subjectA, subjectB, subjectRange);
479479
}
480480

0 commit comments

Comments
 (0)