Skip to content

Add telemetry event when startup is over 30 seconds #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TylerLeonhardt opened this issue Apr 23, 2020 · 3 comments
Open

Add telemetry event when startup is over 30 seconds #2657

TylerLeonhardt opened this issue Apr 23, 2020 · 3 comments
Labels

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Apr 23, 2020

Summary of the new feature

We recently added #2653 a notice to the user after 30 seconds that says "it's taking longer than expected to start up"

We should also add a telemetry point to capture when this happens so we can see how frequent it occurs. If it occurs a lot, then we can prioritize startup perf.

Proposed technical implementation details (optional)

Added telemetry event called "SlowStartup" that basically captures:

  • OS (provided by vscode telemetry module)
  • VS Code version (provided by vscode telemetry module)
  • PS ext version (provided by vscode telemetry module)
  • PS version

this basically is a copy-paste of our exist telemetry point:

this.telemetryReporter.sendTelemetryEvent("powershellVersionCheck",
{ powershellVersion: versionDetails.version });

cc @rjmholt @SydneyhSmith @SteveL-MSFT

@TylerLeonhardt
Copy link
Member Author

Potentially worth including a telemetry point when the timeout is exceeded as well.

@SydneyhSmith SydneyhSmith added this to the vNext milestone Apr 28, 2020
@EdCallahan
Copy link

A couple notes about the WaitForSessionFile logic cleanup at #2653 that might effect how you implement telemetry, or at least the data you can hope to collect via telemetry.

When the session file is not found because of BeyondTrust/Avecto privilege management, VS Code is unresponsive. The user gets the "The window is no longer responding" dialog periodically:

image

When the session file is found, or the timeout is hit, the warning message is shown at the same time as the "Language service could not be started" message. The "Loading is taking longer than expected" is not shown at powershell.developer.waitForSessionFileNumOfTries / 2, it is shown when the session file is found, the timeout is exceeded, or sometime after that. But the two dialogs appear at the same time.

image

VS Code can stay unresponsive well past the powershell.developer.waitForSessionFileNumOfTries timeout. 5 minutes or more.

A believe this is an Avecto problem, not a code problem. But I mention it because if the telemetry is silent that will not mean there is not a problem. I assume that while VS Code is unresponsive it simply will not send telemetry.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label May 13, 2020
@TylerLeonhardt
Copy link
Member Author

I assume that while VS Code is unresponsive it simply will not send telemetry.

This is a good point. Thanks @EdCallahan

@SydneyhSmith SydneyhSmith removed the Needs: Maintainer Attention Maintainer attention needed! label May 14, 2020
@SydneyhSmith SydneyhSmith removed this from the vNext milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants