Skip to content

PSEditorServices doesn't work when machine is DeviceGuard enabled #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SteveL-MSFT opened this issue Sep 28, 2018 · 14 comments
Closed

PSEditorServices doesn't work when machine is DeviceGuard enabled #754

SteveL-MSFT opened this issue Sep 28, 2018 · 14 comments
Labels
Area-Startup Issue-Enhancement A feature request (enhancement).

Comments

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Sep 28, 2018

Enterprises that leverage DeviceGuard has PowerShell running in constrained language mode which prevents VSCode+PS from working. Need to investigate what is happening and find appropriate solution.

@rjmholt
Copy link
Contributor

rjmholt commented Sep 28, 2018

@SeeminglyScience
Copy link
Collaborator

We could just convert the whole start up script to a cmdlet. That would probably help with start up performance anyway.

@rjmholt
Copy link
Contributor

rjmholt commented Sep 28, 2018

I have been thinking about exactly that as well

@rjmholt
Copy link
Contributor

rjmholt commented Sep 28, 2018

As long as we can make it work properly across .NET platfroms, I'm onboard

@SeeminglyScience
Copy link
Collaborator

Side note so it doesn't get forgotten: Part of start up is creating a second runspace so we can use our custom host from powershell.exe/pwsh. We'll need to make sure we propagate the language mode there. We should also test that none of our internal commands (like the ones to get the call stack, computer name, etc) break in constrained language.

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Sep 29, 2018

I've always wondered why Start-EditorServices.ps1 existed when we have PowerShellEditorServices.psm1 that gets imported by Start-EditorServices.ps1.

@TylerLeonhardt
Copy link
Member

@SeeminglyScience did you mean a binary module?

@SeeminglyScience
Copy link
Collaborator

@tylerl0706 Yeah. The term "cmdlet" is sometimes used interchangeably with "command" but it does specifically refer to a command from a binary module.

@AndrewCi
Copy link

AndrewCi commented Jun 6, 2019

Any update on this? Is there a current workaround? Currently running into this issue with constrained language mode.

@rjmholt
Copy link
Contributor

rjmholt commented Jun 6, 2019

Any update on this? Is there a current workaround? Currently running into this issue with constrained language mode.

No, we currently don't support Constrained Language Mode.

We haven't prioritised the work, but may be able to get it as part of other work we're doing this year.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Dec 12, 2019
@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Dec 12, 2019
@jasonadsit
Copy link

I look forward to this getting fixed as well. VSCode not supporting constrained language mode has been a stumbling block for me for awhile now as well.

@Jared-Harrington-Gibbs
Copy link

I've also encountered this issue and I'm definitely looking forward to this getting fixed.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Jun 5, 2020
@TylerLeonhardt
Copy link
Member

@Jared-Harrington-Gibbs can you try the PowerShell Preview extension? That should have support for Constrained Language Mode.

We can close this issue since this is in the PowerShell Preview extension.

@TylerLeonhardt TylerLeonhardt removed the Needs: Maintainer Attention Maintainer attention needed! label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Startup Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

8 participants