Skip to content

Remove bundled PSScriptAnalyzer, use installed module's cmdlet instead #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daviwil opened this issue Apr 28, 2016 · 2 comments
Closed

Remove bundled PSScriptAnalyzer, use installed module's cmdlet instead #213

daviwil opened this issue Apr 28, 2016 · 2 comments
Assignees
@daviwil
Labels
Issue-Enhancement A feature request (enhancement).
Milestone
0.7.0

Comments

@daviwil
Copy link
Contributor

daviwil commented Apr 28, 2016

We currently ship PSScriptAnalyzer as a DLL dependency to PowerShell Editor Services when we release updates to the VS Code extension. We should change our approach to use the user's currently-installed PSScriptAnalyzer module and invoke its cmdlets instead of using it as a C# API.

We might ultimately need some extra logic to only use a version of the module within a certain range in case we need to avoid breaking changes to the cmdlets, though I think that's not extremely likely to happen in the short torm.

I'll try to get this in for 0.6.0 but if I don't have time I'll do it for 0.7.0.
@daviwil daviwil self-assigned this Apr 28, 2016
@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Apr 28, 2016
@daviwil daviwil added this to the 0.6.0 milestone Apr 28, 2016
@daviwil daviwil changed the title Remove bundled PSScriptAnalyzer, use installed copy as cmdlet Remove bundled PSScriptAnalyzer, use installed module's cmdlet instead Apr 28, 2016
@daviwil
Copy link
Contributor Author

daviwil commented May 11, 2016

Don't have time to finish this for 0.6.0, will do it in 0.7.0 instead.

@daviwil daviwil modified the milestones: 0.7.0, 0.6.0 May 11, 2016
@daviwil daviwil mentioned this issue May 18, 2016
Open
@daviwil
Copy link
Contributor Author

daviwil commented Sep 2, 2016

@kapilmb did this work and it got shipped with 0.7.0! Closing this issue.

@daviwil daviwil closed this as completed Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daviwil daviwil

Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@daviwil