From e6e9f06cdb6e268f9850d9bd49ca14005be68153 Mon Sep 17 00:00:00 2001 From: Christoph Bergmeister Date: Sat, 3 Feb 2018 21:34:39 +0000 Subject: [PATCH 1/4] Add simple GitHub Pull Request template based off the one for PowerShell Core --- .github/PULL_REQUEST_TEMPLATE.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..f44154d7c --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,16 @@ +## PR Summary + + + +## PR Checklist + +Note: Please mark anything not applicable to this PR `NA`. + +- [ ] PR has a meaningful title + - [ ] Use the present tense and imperative mood when describing your changes +- [ ] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) +- [ ] User facing documentation needed +- [ ] Change is not breaking +- [ ] Make sure you've added a new test if existing tests do not effectively test the code changed +- [ ] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress). + - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready. From e50f777226551c39368aaa8ce4173fa3834db91b Mon Sep 17 00:00:00 2001 From: Christoph Bergmeister Date: Sat, 3 Feb 2018 21:39:14 +0000 Subject: [PATCH 2/4] update pr template with help for people that are not familiar with markdown --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f44154d7c..974589af7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,7 +4,7 @@ ## PR Checklist -Note: Please mark anything not applicable to this PR `NA`. +Note: Tick the boxes below that apply to this pull request by putting an `x` between the square brackets. Please mark anything not applicable to this PR `NA`. - [ ] PR has a meaningful title - [ ] Use the present tense and imperative mood when describing your changes From 2573a77e65f683974b1178593dd9743407233b03 Mon Sep 17 00:00:00 2001 From: Christoph Bergmeister Date: Sat, 3 Feb 2018 21:43:43 +0000 Subject: [PATCH 3/4] remove powershell core specific links --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 974589af7..5a932781e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,9 +8,9 @@ Note: Tick the boxes below that apply to this pull request by putting an `x` bet - [ ] PR has a meaningful title - [ ] Use the present tense and imperative mood when describing your changes -- [ ] [Summarized changes](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission) +- [ ] Summarized changes - [ ] User facing documentation needed - [ ] Change is not breaking - [ ] Make sure you've added a new test if existing tests do not effectively test the code changed -- [ ] This PR is ready to merge and is not [Work in Progress](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---work-in-progress). +- [ ] This PR is ready to merge and is not wWork in progress - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready. From a113326a0d5da6cc8864f4ec3a8802226537b3e8 Mon Sep 17 00:00:00 2001 From: Christoph Bergmeister Date: Sat, 3 Feb 2018 22:51:51 +0000 Subject: [PATCH 4/4] fix typo --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5a932781e..c62f4f6d8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -12,5 +12,5 @@ Note: Tick the boxes below that apply to this pull request by putting an `x` bet - [ ] User facing documentation needed - [ ] Change is not breaking - [ ] Make sure you've added a new test if existing tests do not effectively test the code changed -- [ ] This PR is ready to merge and is not wWork in progress - - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready. +- [ ] This PR is ready to merge and is not work in progress + - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready