Skip to content

Script rule documentation issues #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MWL88 opened this issue Mar 21, 2018 · 1 comment
Closed

Script rule documentation issues #941

MWL88 opened this issue Mar 21, 2018 · 1 comment

Comments

@MWL88
Copy link
Contributor

MWL88 commented Mar 21, 2018

There are a couple of issues with ScriptRuleDocumentation.md

  1. A typo in the following sentence:

The purpose of this documentation is to server as a basic guide on creating your own customized rules.

The word 'server' should be 'serve'.

  1. The documentation describing the parameters for a script rule is incomplete. Having reviewed the PSSA source code, I believe the documentation does not:
  • describe all the possible parameters
  • specify the parameter naming restrictions
@MWL88 MWL88 mentioned this issue Mar 21, 2018
Merged
7 tasks
@MWL88
Copy link
Contributor Author

MWL88 commented Mar 21, 2018

PR #942 was merged

@MWL88 MWL88 closed this as completed Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MWL88