Error handling and error messages

[juneb]

I've seen several cases like this one where we write a non-terminating error and then provide results. We need to review our error handling. Should this be a terminating error? Or, should it be an error that the end-user sees? How should the user fix this error?

PS C:\ps-test> Invoke-ScriptAnalyzer -ScriptDefinition "function get-Widgets { Hello, World }"
Invoke-ScriptAnalyzer : Parse error in script definition: Missing argument in parameter list at line 1 column 29.
At line:1 char:1

• Invoke-ScriptAnalyzer -ScriptDefinition "function get-Widgets { Hello ...

• - CategoryInfo          : ParserError: (MissingArgument:String) [Invoke-ScriptAnalyzer], ParseException
  - FullyQualifiedErrorId : Parse error in script definition:  Missing argument in parameter list at line 1 column 29.,Micr
    osoft.Windows.PowerShell.ScriptAnalyzer.Commands.InvokeScriptAnalyzerCommand
  
  

RuleName Severity FileName Line Message

---

PSUseSingularNouns Warning 1 The cmdlet 'get-Widgets' uses a plural noun. A singular
noun should be used instead.

[raghushantha]

Hi June.

Parsing errors are non-terminating and the Engine continues to run rules against the provided Scripts.

We have a discussion around converting these errors to DiagnosticRecords - to provide a unified experience in the output.
#264

The only terminating errors would be when using CustomRulePaths and Profiles (Configurations)

[raghushantha]

We have a consistent experience for error cases in v1.2.0 of ScriptAnalyzer. Please try it out and let us know if you have feedback.