Merge pull request #1011 from bergmeister/remove_build.cmd

Remove redundant/outdated build scripts and cleanup

Author: JamesWTruher

.build.ps1

@@ -0,0 +1,8 @@
+{
+    // See http://go.microsoft.com/fwlink/?LinkId=827846
+    // for the documentation about the extensions.json format
+    "recommendations": [
+        "ms-vscode.PowerShell",
+        "ms-vscode.csharp"
+    ]
+}

.vscode/extensions.json

@@ -1,5 +1,8 @@
 // Place your settings in this file to overwrite default and user settings.
 {
     "editor.tabSize": 4,
-    "powershell.codeFormatting.preset": "Allman"
-}
+    "powershell.codeFormatting.preset": "Allman",
+    "[powershell]": {
+        "files.trimTrailingWhitespace": true
+    }
+}

.vscode/settings.json

@@ -33,7 +33,7 @@ Function Get-SolutionRoot
 Function Get-RuleProjectRoot
 {
     $slnRoot = Get-SolutionRoot
-    if ($slnRoot -eq $null)
+    if ($null -eq $slnRoot)
     {
         return $null
     }
@@ -43,7 +43,7 @@ Function Get-RuleProjectRoot
 Function Get-RuleProjectFile
 {
     $prjRoot = Get-RuleProjectRoot
-    if ($prjRoot -eq $null)
+    if ($null -eq $prjRoot)
     {
         return $null
     }

Utils/RuleMaker.psm1

@@ -16,7 +16,6 @@ environment:
 # cache Nuget packages and dotnet CLI cache
 cache:
   - '%USERPROFILE%\.nuget\packages -> appveyor.yml'
-  - '%LocalAppData%\Microsoft\dotnet -> appveyor.yml'
 
 install:
   - ps:   if ($env:PowerShellEdition -eq 'WindowsPowerShell') { Import-Module .\tools\appveyor.psm1; Invoke-AppveyorInstall }

appveyor.yml

@@ -1,16 +1,11 @@
+# This function might be a partially out of date and only the -BuildDoc switch is guaranteed to work since it is used and needed for the build process.
 [CmdletBinding()]
 param(
 
     [Parameter(ParameterSetName='Build')]
     [ValidateSet('PSV3 Debug','PSV3 Release','Debug','Release')]
     [string] $Configuration = 'Debug',
 
-    [Parameter(ParameterSetName='Build')]
-    [switch] $BuildSolution = $false,
-
-    [Parameter(ParameterSetName='Build')]
-    [switch] $CleanSolution = $false,
-
     [Parameter(ParameterSetName='Build')]
     [switch] $BuildDocs = $false,
 
@@ -63,27 +58,11 @@ if (-not (Test-Path $solutionPath))
     throw $errMsg
 }
 
-$buildCmd = Join-Path $projectRoot "build.cmd"
-if (-not (Test-Path $buildCmd))
-{
-    throw "cannot find build.cmd"
-}
-
 if ($CleanOutput)
 {
     Remove-Item -Recurse $outPath\* -Force -Verbose:$verbosity
 }
 
-if ($CleanSolution)
-{
-    & $buildCmd $solutionPath $Configuration 'clean'
-}
-
-if ($BuildSolution)
-{
-    & $buildCmd $solutionPath $Configuration
-}
-
 if ($BuildDocs)
 {
     $docsPath = Join-Path $projectRoot 'docs'
@@ -98,7 +77,7 @@ if ($BuildDocs)
     {
         "Cannot find required minimum version $requiredVersionOfplatyPS of platyPS. Please install it from https://www.powershellgallery.com/packages/platyPS/ using e.g. the following command: Install-Module platyPS"
     }
-    if ((Get-Module platyPS -Verbose:$verbosity) -eq $null)
+    if ($null -eq (Get-Module platyPS -Verbose:$verbosity))
     {
         Import-Module platyPS -Verbose:$verbosity
     }
@@ -111,7 +90,7 @@ if ($BuildDocs)
 
 # Appveyor errors out due to $profile being null. Hence...
 $moduleRootPath = "$HOME/Documents/WindowsPowerShell/Modules"
-if ($profile -ne $null)
+if ($null -ne $profile)
 {
     $moduleRootPath = Join-Path (Split-Path $profile) 'Modules'
 }

build.cmd

@@ -10,7 +10,7 @@
     [string]$Configuration = "Debug"
 )
 
-if ($Configuration -match "PSv3" -and $Framework -eq "netstandard2.0")
+if ($Configuration -match "PSv" -and $Framework -eq "netstandard2.0")
 {
     throw ("{0} configuration is not applicable to {1} framework" -f $Configuration,$Framework)
 }
@@ -45,13 +45,8 @@ elseif ($Configuration -match 'PSv4') {
 
 if ($build)
 {
-
-    Write-Progress "Building Engine"
-    Push-Location Engine\
-    dotnet build Engine.csproj --framework $Framework --configuration $Configuration
-    Pop-Location
-
     Write-Progress "Building for framework $Framework, configuration $Configuration"
+    # The Rules project has a dependency on the Engine therefore just building the Rules project is enough
     Push-Location Rules\
     dotnet build Rules.csproj --framework $Framework --configuration $Configuration
     Pop-Location