Skip to content

"quack" is broken #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bvssvni opened this issue Jan 11, 2015 · 3 comments
Closed

"quack" is broken #812

bvssvni opened this issue Jan 11, 2015 · 3 comments

Comments

@bvssvni
Copy link
Member

bvssvni commented Jan 11, 2015

The problem is when a property type is reexported and implemented with GetFrom, SetAt or ActOn for a type in that crate. Because the Self parameter does not contain the local defined type, it is not allowed by the new rules.

See PistonDevelopers/quack#3

I haven't managed to make SetAt work with the new rules. It either gets lifetime issues or can not infer static method call on traits.

@bvssvni
Copy link
Member Author

bvssvni commented Jan 11, 2015

We could go back to the Window trait and auto implement it for &RefCell<T> and Rc<RefCell<T>>.

piston-graphics can be redesigned with normal methods.

The planned redesign to use the builder traits of Conrod will then be dropped.

@bvssvni
Copy link
Member Author

bvssvni commented Jan 11, 2015

We could still use the same naming conventions:

.set_mut_ups(60) Returns a mutable reference to self

.set_ups(60).set_fps(60) Returns self by value

@bvssvni
Copy link
Member Author

bvssvni commented Jan 11, 2015

Wait, there might still be a solution.

@bvssvni bvssvni closed this as completed Jan 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant