From 56a0fd5154fa70024f05e2dcf730d3e51e7c34d7 Mon Sep 17 00:00:00 2001 From: Mohamed EL Habib Date: Sun, 19 May 2019 13:54:44 +0200 Subject: [PATCH 1/2] added fail-on-incompatible option --- README.md | 1 + src/main/java/com/qdesrame/openapi/diff/Main.java | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/README.md b/README.md index 2711d5100..e260bda17 100644 --- a/README.md +++ b/README.md @@ -76,6 +76,7 @@ usage: openapi-diff --query use query param for authorisation --state Only output diff state: no_changes, incompatible, compatible + --fail-on-incompatible Fail only if API changes broke backward compatibility --trace be extra verbose --version print the version information and exit --warn Print warning information diff --git a/src/main/java/com/qdesrame/openapi/diff/Main.java b/src/main/java/com/qdesrame/openapi/diff/Main.java index 104bbde18..095f34ca1 100644 --- a/src/main/java/com/qdesrame/openapi/diff/Main.java +++ b/src/main/java/com/qdesrame/openapi/diff/Main.java @@ -28,6 +28,16 @@ public static void main(String... args) { .longOpt("state") .desc("Only output diff state: no_changes, incompatible, compatible") .build()); + options.addOption( + Option.builder() + .longOpt("state") + .desc("Only output diff state: no_changes, incompatible, compatible") + .build()); + options.addOption( + Option.builder() + .longOpt("fail-on-incompatible") + .desc("Fail only if API changes broke backward compatibility") + .build()); options.addOption(Option.builder().longOpt("trace").desc("be extra verbose").build()); options.addOption( Option.builder().longOpt("debug").desc("Print debugging information").build()); @@ -179,6 +189,8 @@ public static void main(String... args) { if (line.hasOption("state")) { System.out.println(result.isChanged().getValue()); System.exit(0); + } else if (line.hasOption("fail-on-incompatible")) { + System.exit(result.isCompatible() ? 0 : 1); } else { System.exit(result.isUnchanged() ? 0 : 1); } From 14ab8b7f9c7d77e8cb5e73d77528e95344b9b257 Mon Sep 17 00:00:00 2001 From: Mohamed EL Habib Date: Sun, 19 May 2019 14:12:54 +0200 Subject: [PATCH 2/2] added fail-on-incompatible option --- src/main/java/com/qdesrame/openapi/diff/Main.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/main/java/com/qdesrame/openapi/diff/Main.java b/src/main/java/com/qdesrame/openapi/diff/Main.java index 095f34ca1..4a254fc39 100644 --- a/src/main/java/com/qdesrame/openapi/diff/Main.java +++ b/src/main/java/com/qdesrame/openapi/diff/Main.java @@ -28,11 +28,6 @@ public static void main(String... args) { .longOpt("state") .desc("Only output diff state: no_changes, incompatible, compatible") .build()); - options.addOption( - Option.builder() - .longOpt("state") - .desc("Only output diff state: no_changes, incompatible, compatible") - .build()); options.addOption( Option.builder() .longOpt("fail-on-incompatible")