Skip to content

Add details in output (html/markdown/console) for changes in schema #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quen2404 opened this issue Jan 12, 2018 · 6 comments
Open

Comments

@quen2404
Copy link
Member

More details should be available for schema changes.

  • Property path
  • Changes detail
@jmini
Copy link
Member

jmini commented Feb 12, 2018

I had a look at the code. As far as can tell, the information is already present in the ChangedXxxx objects (com.qdesrame.openapi.diff.model package) instanciated by the compare engine. I could browse one ChangedOpenApi instance to see exactly what changed at property level.

I guess this issue is about having a nicer description in the report.

@quen2404
Copy link
Member Author

Yes exactly ! The information is present in ChangedXxxx but not in result currently ! I have to develop the implementation in the XxxxRenderer classes.

@quen2404 quen2404 changed the title Add details for changes in schema Add details in output (html/markdown/console) for changes in schema Feb 12, 2018
@thiagoarrais
Copy link
Contributor

Is this still useful? I'm interested in working on a PR.

@cminini
Copy link

cminini commented Oct 23, 2019

Looking forward to this feature. Thanks @thiagoarrais

@thiagoarrais
Copy link
Contributor

@cminini: have you taken a look at my PR? I'd really love some feedback.

@michalchmura
Copy link

This would be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants