Fix DiffContext bug

Author: quen2404

src/main/java/com/qdesrame/openapi/diff/compare/ApiResponseDiff.java

@@ -29,8 +29,6 @@ public Optional<ChangedApiResponse> diff(ApiResponses left, ApiResponses right,
         changedApiResponse.setAddResponses(responseMapKeyDiff.getIncreased());
         changedApiResponse.setMissingResponses(responseMapKeyDiff.getMissing());
         List<String> sharedResponseCodes = responseMapKeyDiff.getSharedKey();
-        context.setRequest(false);
-        context.setResponse(true);
         Map<String, ChangedResponse> resps = new HashMap<>();
         for (String responseCode : sharedResponseCodes) {
             openApiDiff.getResponseDiff().diff(left.get(responseCode), right.get(responseCode), context)

src/main/java/com/qdesrame/openapi/diff/compare/OperationDiff.java

@@ -29,7 +29,7 @@ public Optional<ChangedOperation> diff(Operation oldOperation, Operation newOper
         changedOperation.setDeprecated(!Boolean.TRUE.equals(oldOperation.getDeprecated()) && Boolean.TRUE.equals(newOperation.getDeprecated()));
 
         if (oldOperation.getRequestBody() != null || newOperation.getRequestBody() != null) {
-            openApiDiff.getRequestBodyDiff().diff(oldOperation.getRequestBody(), newOperation.getRequestBody(), context)
+            openApiDiff.getRequestBodyDiff().diff(oldOperation.getRequestBody(), newOperation.getRequestBody(), context.copyAsRequest())
                     .ifPresent(changedOperation::setChangedRequestBody);
         }
 
@@ -40,7 +40,7 @@ public Optional<ChangedOperation> diff(Operation oldOperation, Operation newOper
                 });
 
         if (oldOperation.getResponses() != null || newOperation.getResponses() != null) {
-            openApiDiff.getApiResponseDiff().diff(oldOperation.getResponses(), newOperation.getResponses(), context)
+            openApiDiff.getApiResponseDiff().diff(oldOperation.getResponses(), newOperation.getResponses(), context.copyAsResponse())
                     .ifPresent(changedOperation::setChangedApiResponse);
         }
 

src/main/java/com/qdesrame/openapi/diff/compare/PathDiff.java

@@ -31,8 +31,7 @@ public Optional<ChangedPath> diff(PathItem left, PathItem right, DiffContext con
         for (PathItem.HttpMethod method : sharedMethods) {
             Operation oldOperation = oldOperationMap.get(method);
             Operation newOperation = newOperationMap.get(method);
-            context.setMethod(method);
-            openApiDiff.getOperationDiff().diff(oldOperation, newOperation, context).ifPresent(changedPath.getChanged()::add);
+            openApiDiff.getOperationDiff().diff(oldOperation, newOperation, context.copyWithMethod(method)).ifPresent(changedPath.getChanged()::add);
         }
         return isChanged(changedPath);
     }

src/main/java/com/qdesrame/openapi/diff/compare/RequestBodyDiff.java

@@ -46,9 +46,6 @@ protected Optional<ChangedRequestBody> computeDiff(HashSet<String> refSet, Reque
                 newRequestContent = newRequestBody.getContent();
             }
         }
-        context.setRequest(true);
-        context.setResponse(false);
-
         ChangedRequestBody changedRequestBody = new ChangedRequestBody(oldRequestBody, newRequestBody, context);
 
         boolean leftRequired = oldRequestBody != null && Boolean.TRUE.equals(oldRequestBody.getRequired());

src/main/java/com/qdesrame/openapi/diff/model/DiffContext.java

@@ -1,21 +1,93 @@
 package com.qdesrame.openapi.diff.model;
 
 import io.swagger.v3.oas.models.PathItem;
-import lombok.Getter;
-import lombok.Setter;
 
+import java.util.HashMap;
 import java.util.Map;
 
 /**
  * Created by Quentin Desramé on 04/04/17.
  */
-@Getter
-@Setter
 public class DiffContext {
 
     private String url;
     private Map<String, String> parameters;
     private PathItem.HttpMethod method;
     private boolean response;
     private boolean request;
+
+    public DiffContext() {
+        parameters = new HashMap<>();
+        response = false;
+        request = true;
+    }
+
+    public DiffContext copyWithMethod(PathItem.HttpMethod method) {
+        return copy().setMethod(method);
+    }
+
+    public DiffContext copyAsRequest() {
+        return copy().setRequest();
+    }
+
+    public DiffContext copyAsResponse() {
+        return copy().setResponse();
+    }
+
+    private DiffContext setRequest() {
+        this.request = true;
+        this.response = false;
+        return this;
+    }
+
+    private DiffContext setResponse() {
+        this.response = true;
+        this.request = false;
+        return this;
+    }
+
+    public boolean isResponse() {
+        return this.response;
+    }
+
+    public boolean isRequest() {
+        return this.request;
+    }
+
+    public String getUrl() {
+        return url;
+    }
+
+    public DiffContext setUrl(String url) {
+        this.url = url;
+        return this;
+    }
+
+    public PathItem.HttpMethod getMethod() {
+        return method;
+    }
+
+    private DiffContext setMethod(PathItem.HttpMethod method) {
+        this.method = method;
+        return this;
+    }
+
+    private DiffContext copy() {
+        DiffContext context = new DiffContext();
+        context.url = this.url;
+        context.parameters = this.parameters;
+        context.method = this.method;
+        context.response = this.response;
+        context.request = this.request;
+        return context;
+    }
+
+    public Map<String, String> getParameters() {
+        return parameters;
+    }
+
+    public DiffContext setParameters(Map<String, String> parameters) {
+        this.parameters = parameters;
+        return this;
+    }
 }

src/test/resources/backwardCompatibility/bc_2.yaml

@@ -131,6 +131,9 @@ components:
       properties:
         bark:
           type: string
+        test:
+          writeOnly: true
+          type: string
     Lizard:
       type: object
       properties:

src/test/resources/backwardCompatibility/bc_3.yaml

@@ -144,6 +144,9 @@ components:
       properties:
         bark:
           type: string
+        test:
+          writeOnly: true
+          type: string
     Lizard:
       type: object
       properties:

src/test/resources/backwardCompatibility/bc_4.yaml

@@ -136,6 +136,9 @@ components:
       properties:
         bark:
           type: string
+        test:
+          writeOnly: true
+          type: string
     Lizard:
       type: object
       properties: