pumpmanager-changes (#3)

* Modal presentation of CGMManager settings.

* Don't push root viewcontroller

* update to pumpmanager-updates

* Setup controller is shown modally

* Use dev LoopKit

* Cartfile should be pointing to LoopKit dev

Author: ps2

Cartfile

@@ -1 +1 @@
-github "LoopKit/LoopKit" ~> 2.0
+github "LoopKit/LoopKit" "dev"

Cartfile.resolved

@@ -1 +1 @@
-github "LoopKit/LoopKit" "v2.2.1"
+github "LoopKit/LoopKit" "bf4166bc77f89e22971f2030ad006967881ff082"

ShareClientUI/ShareClientManager+UI.swift

@@ -11,12 +11,14 @@ import ShareClient
 
 
 extension ShareClientManager: CGMManagerUI {
-    public static func setupViewController() -> (UIViewController & CGMManagerSetupViewController)? {
+    public static func setupViewController() -> (UIViewController & CGMManagerSetupViewController & CompletionNotifying)? {
         return ShareClientSetupViewController()
     }
 
-    public func settingsViewController(for glucoseUnit: HKUnit) -> UIViewController {
-        return ShareClientSettingsViewController(cgmManager: self, glucoseUnit: glucoseUnit, allowsDeletion: true)
+    public func settingsViewController(for glucoseUnit: HKUnit) -> (UIViewController & CompletionNotifying) {
+        let settings = ShareClientSettingsViewController(cgmManager: self, glucoseUnit: glucoseUnit, allowsDeletion: true)
+        let nav = SettingsNavigationViewController(rootViewController: settings)
+        return nav
     }
 
     public var smallImage: UIImage? {

ShareClientUI/ShareClientSettingsViewController.swift

@@ -45,6 +45,19 @@ public class ShareClientSettingsViewController: UITableViewController {
 
         tableView.register(SettingsTableViewCell.self, forCellReuseIdentifier: SettingsTableViewCell.className)
         tableView.register(TextButtonTableViewCell.self, forCellReuseIdentifier: TextButtonTableViewCell.className)
+
+        let button = UIBarButtonItem(barButtonSystemItem: .done, target: self, action: #selector(doneTapped(_:)))
+        self.navigationItem.setRightBarButton(button, animated: false)
+    }
+
+    @objc func doneTapped(_ sender: Any) {
+        complete()
+    }
+
+    private func complete() {
+        if let nav = navigationController as? SettingsNavigationViewController {
+            nav.notifyComplete()
+        }
     }
 
     // MARK: - UITableViewDataSource
@@ -168,7 +181,7 @@ public class ShareClientSettingsViewController: UITableViewController {
         case .delete:
             let confirmVC = UIAlertController(cgmDeletionHandler: {
                 self.cgmManager.cgmManagerDelegate?.cgmManagerWantsDeletion(self.cgmManager)
-                self.navigationController?.popViewController(animated: true)
+                self.complete()
             })
 
             present(confirmVC, animated: true) {

ShareClientUI/ShareClientSetupViewController.swift

@@ -11,9 +11,11 @@ import LoopKitUI
 import ShareClient
 
 
-class ShareClientSetupViewController: UINavigationController, CGMManagerSetupViewController {
+class ShareClientSetupViewController: UINavigationController, CGMManagerSetupViewController, CompletionNotifying {
     var setupDelegate: CGMManagerSetupViewControllerDelegate?
 
+    weak var completionDelegate: CompletionDelegate?
+
     let cgmManager = ShareClientManager()
 
     init() {
@@ -37,11 +39,11 @@ class ShareClientSetupViewController: UINavigationController, CGMManagerSetupVie
     }
 
     @objc private func cancel() {
-        setupDelegate?.cgmManagerSetupViewControllerDidCancel(self)
+        completionDelegate?.completionNotifyingDidComplete(self)
     }
 
     @objc private func save() {
         setupDelegate?.cgmManagerSetupViewController(self, didSetUpCGMManager: cgmManager)
+        completionDelegate?.completionNotifyingDidComplete(self)
     }
-
 }