should be able to edit/extrude sketch with no variable declaration

[jessfraz]

see video

Screenshare.-.2024-08-01.3_45_27.PM.mp4

more info here https://kittycadworkspace.slack.com/archives/C04KFV6NKL0/p1722552201055069

[jtran]

The app is trying to go through this path:

source range selection -> pathToNode -> call AST node -> variable declaration AST node -> variable name -> variable value in ProgramMemory (should be ExtrudeGroup or SketchGroup) -> face or plane

Unfortunately, that's impossible unless the KCL has assigned the pipeline to a variable. If you add let x = to the first line, all problems go away. The assumption that there is a variable is deeply ingrained.

To fix this right, we need @Irev-Dev's changes from #3140 so that we can find the face or plane from an arbitrary UUID that the user has clicked.

In the meantime, I thought we could require KCL authors to always use a variable. A parse error would hopefully guide users to fixing their code.

Is it easy to make an auto-fix that can migrate users' code? That would be ideal.

But also, the variable requirement would go away once the artifact graph was completed.

[jessfraz]

id rather just disable the button on these? is that possible or we wait for kurts change because changing kcl is not going to work that will break everyone more

[jessfraz]

@Irev-Dev can you get in your PR by our monday?

[jtran]

It should be possible to disable the button until Kurt's change is in.

[Irev-Dev]

The change is in!

[Irev-Dev]

Temp fix to stop user from getting into a bad state is here: #3292
Not closing this issue out yet though.
Quick explanation

Screenshare.-.2024-08-06.3_01_07.PM.mp4

[Irev-Dev]

Maybe this needs to be a lint that adds a variable when users type this.

[franknoirot]

This affects users who:

1. have hand-written some KCL manually for a sketch, which is not the primary way to interact with the app
2. have a sketch that cannot be used anywhere else in their program, because it has no identifier assignment
3. want to edit this nameless, unusable sketch via point-and-click

I think that's a vanishingly small group of users. I'm removing high-priority tag. I agree with @Irev-Dev that this would be helped most of all by a lint.