Skip to content

Commit 6fc8387

Browse files
committed
Refactor deprecated experimental configuration messages
1 parent 927209a commit 6fc8387

File tree

5 files changed

+28
-27
lines changed

5 files changed

+28
-27
lines changed

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/dsl/ExperimentalExtension.kt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,21 @@ package org.jetbrains.compose.experimental.dsl
77

88
import org.gradle.api.Action
99
import org.gradle.api.model.ObjectFactory
10+
import org.jetbrains.compose.internal.DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB_IN_CONFIGURATION
1011
import javax.inject.Inject
1112

1213
abstract class ExperimentalExtension @Inject constructor(
1314
objects: ObjectFactory
1415
) {
15-
16+
@Suppress("DEPRECATION")
1617
@Deprecated(
17-
message = "Starting from 1.6.10, Compose for Web goes to Alpha. Experimental configuration is not needed anymore.",
18+
message = DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB_IN_CONFIGURATION,
1819
)
1920
val web: ExperimentalWebExtension = objects.newInstance(ExperimentalWebExtension::class.java)
2021

22+
@Suppress("DEPRECATION")
2123
@Deprecated(
22-
message = "Starting from 1.6.10, Compose for Web goes to Alpha. Experimental configuration is not needed anymore."
24+
message = DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB_IN_CONFIGURATION,
2325
)
24-
fun web(action: Action<ExperimentalWebExtension>) {
25-
action.execute(web)
26-
}
27-
}
26+
fun web(action: Action<ExperimentalWebExtension>): Unit = action.execute(web)
27+
}

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/dsl/ExperimentalWebApplication.kt

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,12 @@
55

66
package org.jetbrains.compose.experimental.dsl
77

8+
import org.jetbrains.compose.internal.DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB_IN_CONFIGURATION
89
import javax.inject.Inject
910

1011
@Deprecated(
11-
message = "Starting from 1.6.10, Compose for Web goes to Alpha. Experimental configuration is not needed anymore.",
12+
message = DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB_IN_CONFIGURATION,
13+
)
14+
abstract class ExperimentalWebApplication @Inject constructor(
15+
@Suppress("unused") val name: String,
1216
)
13-
abstract class ExperimentalWebApplication @Inject constructor(
14-
@Suppress("unused")
15-
val name: String,
16-
) {
17-
18-
}

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/dsl/ExperimentalWebExtension.kt

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,24 @@ package org.jetbrains.compose.experimental.dsl
88
import org.gradle.api.Action
99
import org.gradle.api.model.ObjectFactory
1010
import org.gradle.api.plugins.ExtensionAware
11+
import org.jetbrains.compose.internal.DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB_IN_CONFIGURATION
1112
import javax.inject.Inject
1213

1314
@Deprecated(
14-
message = "Starting from 1.6.10, Compose for Web goes to Alpha. Experimental configuration is not needed anymore.",
15+
message = DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB_IN_CONFIGURATION,
1516
)
1617
abstract class ExperimentalWebExtension @Inject constructor(private val objectFactory: ObjectFactory) : ExtensionAware {
17-
internal var _isApplicationInitialized = false
18-
private set
19-
18+
@Suppress("DEPRECATION")
2019
@Deprecated(
21-
message = "Starting from 1.6.10, Compose for Web goes to Alpha. Experimental configuration is not needed anymore.",
20+
message = DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB_IN_CONFIGURATION,
2221
)
2322
val application: ExperimentalWebApplication by lazy {
24-
_isApplicationInitialized = true
2523
objectFactory.newInstance(ExperimentalWebApplication::class.java, "main")
2624
}
2725

26+
@Suppress("DEPRECATION")
2827
@Deprecated(
29-
message = "Starting from 1.6.10, Compose for Web goes to Alpha. Experimental configuration is not needed anymore.",
28+
message = DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB_IN_CONFIGURATION,
3029
)
31-
fun application(fn: Action<ExperimentalWebApplication>) {
32-
fn.execute(application)
33-
}
30+
fun application(fn: Action<ExperimentalWebApplication>): Unit = fn.execute(application)
3431
}

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/experimental/web/tasks/ExperimentalUnpackSkikoWasmRuntimeTask.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@
55

66
package org.jetbrains.compose.experimental.web.tasks
77

8+
import org.jetbrains.compose.internal.DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB
89
import org.jetbrains.compose.web.tasks.UnpackSkikoWasmRuntimeTask
910

1011
@Deprecated(
11-
message = "Starting from 1.6.10 Compose for Web goes to Alpha",
12+
message = DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB,
1213
replaceWith = ReplaceWith("UnpackSkikoWasmRuntimeTask")
1314
)
14-
abstract class ExperimentalUnpackSkikoWasmRuntimeTask : UnpackSkikoWasmRuntimeTask()
15+
abstract class ExperimentalUnpackSkikoWasmRuntimeTask : UnpackSkikoWasmRuntimeTask()

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/internal/constants.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,9 @@ internal const val KOTLIN_ANDROID_PLUGIN_ID = "org.jetbrains.kotlin.android"
1111
internal const val KOTLIN_JS_PLUGIN_ID = "org.jetbrains.kotlin.js"
1212
internal const val COMPOSE_PLUGIN_ID = "org.jetbrains.compose"
1313

14-
internal const val IDEA_IMPORT_TASK_NAME = "prepareKotlinIdeaImport"
14+
internal const val IDEA_IMPORT_TASK_NAME = "prepareKotlinIdeaImport"
15+
16+
internal const val DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB: String =
17+
"Starting from 1.6.10, Compose for Web goes to Alpha."
18+
internal const val DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB_IN_CONFIGURATION: String =
19+
DEPRECATED_EXPERIMENTAL_MESSAGE_FOR_WEB + "Experimental configuration is not needed anymore."

0 commit comments

Comments
 (0)