Skip to content

Re-export Functions Interface #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grant opened this issue Oct 15, 2021 · 3 comments
Closed

Re-export Functions Interface #355

grant opened this issue Oct 15, 2021 · 3 comments
Assignees

Comments

@grant
Copy link
Contributor

grant commented Oct 15, 2021

We change the exported types for this repo in a previous PR (I think).

https://github.com/GoogleCloudPlatform/functions-framework-nodejs/pull/347/files#r724614498

The types are declared here:

https://github.com/GoogleCloudPlatform/functions-framework-nodejs/blob/master/package.json#L10

They should probably point back to this file:

https://github.com/GoogleCloudPlatform/functions-framework-nodejs/blob/master/src/functions.ts

We should likely re-add these types, since developers would be losing type information otherwise.

@matthewrobertson
Copy link
Member

I made this change intentionally. Nothing should have changed for developers because we re-export everything from functions.ts in index.ts.

@grant
Copy link
Contributor Author

grant commented Oct 15, 2021

I made this change intentionally. Nothing should have changed for developers because we re-export everything from functions.ts in index.ts.

OK. Maybe the API extractor tool is missing some of these interfaces. I'm not quite sure. See:

#354

@grant grant self-assigned this Oct 19, 2021
@grant
Copy link
Contributor Author

grant commented Oct 19, 2021

Fixed with #354

@grant grant closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants