Skip to content

Block merge on negative review #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
silverwind opened this issue Apr 28, 2023 · 1 comment
Closed

Block merge on negative review #73

silverwind opened this issue Apr 28, 2023 · 1 comment

Comments

@silverwind
Copy link
Collaborator

silverwind commented Apr 28, 2023 •
edited
Loading

Might want to reconsider this given recent problem go-gitea/gitea#22854. I think as long as mergers have the option to merge PRs (likely via CLI) with stale negative reviews, it'll work out.
@yardenshoham yardenshoham mentioned this issue Apr 28, 2023
Merged
@silverwind
Copy link
Collaborator Author

Fixed by #63.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@silverwind