Don't ignore change requests when the blocking user is requested to review (#105)

yardenshoham · web-flow · commit cd9cf571b0c0 · 2023-09-01T09:26:32.000+08:00
It's fine to remove approvals by requesting reviews but we shouldn't remove change requests by requesting reviews

Signed-off-by: Yarden Shoham &lt;git@yardenshoham.com&gt;
diff --git a/src/github.ts b/src/github.ts
@@ -307,10 +307,9 @@ export const getPrReviewers = async (
     }
   }
 
-  // any requested reviewers are not approvers nor blockers
+  // any requested reviewers are not approvers
   for (const requestedReviewer of pr.requested_reviewers) {
     approvers.delete(requestedReviewer.login);
-    blockers.delete(requestedReviewer.login);
   }
 
   return { approvers, blockers };

Original file line number	Diff line number	Diff line change
`@@ -307,10 +307,9 @@ export const getPrReviewers = async (`
`307`	`307`	`}`
`308`	`308`	`}`
`309`	`309`
`310`		`- // any requested reviewers are not approvers nor blockers`
	`310`	`+ // any requested reviewers are not approvers`
`311`	`311`	`for (const requestedReviewer of pr.requested_reviewers) {`
`312`	`312`	`approvers.delete(requestedReviewer.login);`
`313`		`- blockers.delete(requestedReviewer.login);`
`314`	`313`	`}`
`315`	`314`
`316`	`315`	`return { approvers, blockers };`