-
Notifications
You must be signed in to change notification settings - Fork 654
[ISSUE]: 6.2.0 seems to be adding unnecessary pre-release suffix to the tag #4480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I got same issue today. I think its about "/config" switch. In my case it looks like cli doesn't use my "/config" path. It loads default configuration. Also its runs okay with 6.1.0 version. I'm checking 6.1.0 and 6.2.0 differences. If i found something further, i'll let you know. |
I have tested it and see that the native gitversion execution works as expected with |
My config, command and output are like below. Tool doesnt use my custom config. Tool uses default configuration. Also i tried relative path like
I uploaded my config as gitversion.txt but its actually gitversion.config. |
Found it! I will give details - and probably a pull request - in couple hours |
In earlier changes there is a change to how should tool locating configuration files. It cause a problem if This isn't a problem before this change merged. In dotnet Path.Combine method handles if path is rooted automatically. But with this pr, tool stops using Path.Combine and starts directly looking under givin directory path. For further information, you can check this Microsoft documentation. In this documentation; we are interested with combine method's examples section - path1 and path3 combine example -. I'm created a pr #4483. Is there any chance to make this hotfix? If its not considered as hotfix, i will change all my pipelines to use 6.1.0 until this pr merged or this issue fixed |
🎉 This issue has been resolved in version 6.3.0 🎉 Your GitReleaseManager bot 📦🚀 |
Uh oh!
There was an error while loading. Please reload this page.
Prerequisites
GitVersion package
GitVersion.Tool
GitVersion version
6.2.0
Operating system
Windows, macOS, Linux
What are you seeing?
Adds a pre-release suffix differently regardless of the operating system:
You can see our GitVersion.yml here: https://github.com/51Degrees/common-ci/blob/main/GitVersion.yml
What is expected?
Previously it was not adding a pre-release suffix:
We expect it to stay that way.
Steps to Reproduce
Steps are specified above
RepositoryFixture Test
No response
Output log or link to your CI build (if appropriate).
The text was updated successfully, but these errors were encountered: