Skip to content

Commit cb4698d

Browse files
committed
Added TODOs for consolidation of AssemblyInfo update logic in GitVersionTask and GitVersionExe
1 parent 1353214 commit cb4698d

File tree

5 files changed

+5
-0
lines changed

5 files changed

+5
-0
lines changed

src/GitVersionExe/AssemblyInfoFileUpdate.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ namespace GitVersion
88
using System.Text.RegularExpressions;
99
using GitVersion.VersionAssemblyInfoResources;
1010

11+
// TODO: Consolidate this with GitVersionTask.UpdateAssemblyInfo. @asbjornu
1112
class AssemblyInfoFileUpdate : IDisposable
1213
{
1314
List<Action> restoreBackupTasks = new List<Action>();

src/GitVersionTask/AssemblyInfoBuilder/AssemblyInfoBuilder.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ public abstract class AssemblyInfoBuilder
1212
{
1313
{ ".cs", typeof(CSharpAssemblyInfoBuilder) },
1414
{ ".vb", typeof(VisualBasicAssemblyInfoBuilder) }
15+
// TODO: Missing FSharpAssemblyInfoBuilder
1516
};
1617

1718
public static AssemblyInfoBuilder GetAssemblyInfoBuilder(IEnumerable<ITaskItem> compileFiles)

src/GitVersionTask/AssemblyInfoBuilder/CSharpAssemblyInfoBuilder.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public override string GetAssemblyInfoText(VersionVariables vars, string rootNam
1111
{
1212
var v = vars.ToList();
1313

14+
// TODO: Consolidate this with GitVersion.VersionAssemblyInfoResources.AssemblyVersionInfoTemplates. @asbjornu
1415
var assemblyInfo = string.Format(
1516
@"//------------------------------------------------------------------------------
1617
// <auto-generated>

src/GitVersionTask/AssemblyInfoBuilder/UpdateAssemblyInfo.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
using Microsoft.Build.Framework;
1111

12+
// TODO: Consolidate this with GitVersion.AssemblyInfoFileUpdate in GitVersionExe. @asbjornu
1213
public class UpdateAssemblyInfo : GitVersionTaskBase
1314
{
1415
TaskLogger logger;

src/GitVersionTask/AssemblyInfoBuilder/VisualBasicAssemblyInfoBuilder.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public override string GetAssemblyInfoText(VersionVariables vars, string rootNam
1111
{
1212
var v = vars.ToList();
1313

14+
// TODO: Consolidate this with GitVersion.VersionAssemblyInfoResources.AssemblyVersionInfoTemplates. @asbjornu
1415
var assemblyInfo = string.Format(
1516
@"'------------------------------------------------------------------------------
1617
' <auto-generated>

0 commit comments

Comments
 (0)