Skip to content
This repository was archived by the owner on Jul 13, 2022. It is now read-only.

Commit 2f4de9a

Browse files
committed
Acknowledgements: Bypass SW, use licence-webpack-plugin
The SW will serve it as index.html (see facebook/create-react-app#2894 ) so bypass it by putting on a subdomain. To get accurate acknowledgements, use the output from licence-webpack-plugin (from the master-with-code-coverage-branch)
1 parent e333b26 commit 2f4de9a

File tree

5 files changed

+419
-5
lines changed

5 files changed

+419
-5
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ TODO
7777
====
7878

7979
List of minor/uninteresting things to do, roughly sorted by priority.
80-
- Make Acknowledge page prettier and fix SW bug!
8180
- make pending message and end-point-of-message move behave the same with regards to lifeline "stickyness"
8281
- Prevent select text inside diagram
8382
- Make <input /> show as multiline when the layout will wrap lines. Use <textarea /> ?

public/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
<div class="footer">
116116
<a target="_blank" rel="noopener noreferrer" href="https://github.com/Enselic/sequencediagram.io"><img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH4QccEywWaqaVZgAAAQZJREFUOMuVkzFqQkEQhv99miqVN3itCF4gkIAH8RCW5gLJAQSxSCmIhwjEWsTSxmdtZdKa+KWZhcm6yXv5Ydnd2f//mRl2JAMQ9x7wAuyBL1t7i/U8Vxnxgnosfpg48Y7m2KUmS3vYAkOgsvvJFhYbGgdgGcV95zxTDYCZ4/cLSSP33lY9PGck4OAcb686nDTbOBGHAFwkBUmfIYSbBhkIOFsmFJL4R/ppGRSSKuc8aFDCwIUqAVPgYjV9AGUi8AYl8O56MI1BgEdgbuc1cOeE98Am86HKSJhYIM7BK9CKGQDtjHiSfuU34Ag8AN1M/R6r3+bhKTL+MHium8gOMM4YjIFOKv4GeqH6/e5I7z8AAAAASUVORK5CYII="/> GitHub</a>
117117
<a target="_blank" rel="noopener noreferrer" href="https://twitter.com/SeqDiag_io"><img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAABmJLR0QA/wD/AP+gvaeTAAAACXBIWXMAAbrVAAG61QFsA6axAAAAB3RJTUUH4QcdCjswFmNrlwAAAV1JREFUOMu1kj1LA0EQhueCaGGS1k5tLKxttVARglj7E6wCdtpZWtiI+B8EG8XSj0oUFMtEA4KQmCAmxphcLre7M7O7Nl64JF6MiAPTzM7zzscOwF/NWvtjzlu1kkTCdWLcaLj18SD+XCyMQrnyGkdSW1GwVGJOG7bG6rYT4z5rygnpT4NCuWystki4AwBgrO4Q0IZVGA6JXArpb4Iv/JkgyJqepBKLAew2G1PfwV8Cx+EqufCjNuyxpkMktRsloFCulkpFACH9FDEeRSVGuZD+LAAA3N7dDHUvaRBPp9Ox9ggKZeo3MGu66tj0/UN2GEkdaMNmwPbnbddvAZLaGwQmpoueY8lmM8HRrBDjaRSsDZfPzk9iH/Va78U13PoEMW73mTtTeM6P+KLVCXotb4kY832qVpHUGgBA03N7CjvWWnAcB95r1bFEIrHgOM4kAMSstS9KqetEPPkI/2mfz+5XJ/wMFUMAAAAASUVORK5CYII="/>@SeqDiag_io</a>
118-
<a target="_blank" rel="noopener noreferrer" href="./acknowledgements.html">Acknowledgements</a>
118+
<a target="_blank" rel="noopener noreferrer" href="http://static.sequencediagram.io/acknowledgements.html">Acknowledgements</a>
119119
<a target="_blank" rel="noopener noreferrer" href="https://github.com/Enselic/sequencediagram.io/releases/tag/v1.2.1-beta" style="margin-left: auto; padding-right: 10px" >v1.2.1-beta</a>
120120
</body>
121121
</html>

src/end-to-end-test/index.test.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ global.sleepIfTransitionsEnabled = function(seconds) {
6969

7070
global.waitForCssTransitions = function() {
7171
if (!transitionsDisabled()) {
72-
sleep(0.3);
72+
return sleep(0.3);
73+
} else {
74+
return true;
7375
}
7476
}
7577

@@ -137,14 +139,14 @@ global.dragAndDrop = function(elementText, offset) {
137139
}
138140

139141
global.click = function(elementText) {
140-
clickElement(findElementByText(elementText));
142+
return clickElement(findElementByText(elementText));
141143
}
142144

143145
global.clickElement = function(element) {
144146
driver.actions()
145147
.click(element)
146148
.perform();
147-
waitForCssTransitions();
149+
return waitForCssTransitions();
148150
}
149151

150152
global.typeAndConfirmm = function(typedText) {

src/end-to-end-test/misc.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,3 +82,14 @@ test('MANUAL: Controls are removed when a message is pending', () => {
8282
goTo('o1,Foo;o2,Bar;m1,o1,o2,MANUAL%20TEST%3A%201.%20Click%20any%20lifeline%20to%20create%20a%20pending%20message.%20Expected%3A%20The%20controls%20for%20this%20message%20shall%20not%20be%20displayed%20when%20hovered%20because%20it%20makes%20the%20UI%20nosiy%20and%20distracting.');
8383
return sleepIfHumanObserver(7);
8484
});
85+
86+
/* why does not this work?
87+
test.only('Clicking Acknowledgements brings us to Acknowledgements', async () => {
88+
goTo('');
89+
await click('Acknowledgements');
90+
await sleep(3);
91+
console.log('waiting');
92+
const title = await driver.getTitle();
93+
expect(title).toEqual("Acknowledgements for https://sequencediagram.io");
94+
});
95+
*/

0 commit comments

Comments
 (0)