Update mypy and pylint (#39164)

Author: lzchen

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_constants.py

@@ -20,7 +20,7 @@
 _DEPENDENCY_FAILURE_RATE_NAME = (
     "azuremonitor.dependencycallsfailedsec",
     "\\ApplicationInsights\\Dependency Calls Failed/Sec",
-)  # pylint: disable=line-too-long
+)
 _DEPENDENCY_DURATION_NAME = ("azuremonitor.dependencycallduration", "\\ApplicationInsights\\Dependency Call Duration")
 # Exception
 _EXCEPTION_RATE_NAME = ("azuremonitor.exceptionssec", "\\ApplicationInsights\\Exceptions/Sec")

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_exporter.py

@@ -83,7 +83,7 @@ class _UnsuccessfulQuickPulsePostError(Exception):
 
 class _QuickpulseExporter(MetricExporter):
 
-    def __init__(self, **kwargs: Any) -> None:  # pylint: disable=unused-argument
+    def __init__(self, **kwargs: Any) -> None:
         """Metric exporter for Quickpulse.
 
         :param str connection_string: The connection string used for your Application Insights resource.
@@ -125,8 +125,8 @@ def __init__(self, **kwargs: Any) -> None:  # pylint: disable=unused-argument
     def export(
         self,
         metrics_data: OTMetricsData,
-        timeout_millis: float = 10_000,  # pylint: disable=unused-argument
-        **kwargs: Any,  # pylint: disable=unused-argument
+        timeout_millis: float = 10_000,
+        **kwargs: Any,
     ) -> MetricExportResult:
         """Exports a batch of metric data
 
@@ -171,7 +171,7 @@ def export(
                 else:
                     # Check if etag has changed
                     etag = post_response._response_headers.get(  # pylint: disable=protected-access
-                        _QUICKPULSE_ETAG_HEADER_NAME  # pylint: disable=protected-access
+                        _QUICKPULSE_ETAG_HEADER_NAME
                     )
                     if etag and etag != configuration_etag:
                         config = (
@@ -182,10 +182,10 @@ def export(
                             # Update and apply configuration changes
                             try:
                                 _update_filter_configuration(etag, config)
-                            except Exception:  # pylint: disable=broad-except,invalid-name
+                            except Exception:  # pylint: disable=broad-except
                                 _logger.exception("Exception occurred while updating filter config.")
                                 result = MetricExportResult.FAILURE
-        except Exception:  # pylint: disable=broad-except,invalid-name
+        except Exception:  # pylint: disable=broad-except
             _logger.exception("Exception occurred while publishing live metrics.")
             result = MetricExportResult.FAILURE
         finally:
@@ -209,8 +209,8 @@ def force_flush(
 
     def shutdown(
         self,
-        timeout_millis: float = 30_000,  # pylint: disable=unused-argument
-        **kwargs: Any,  # pylint: disable=unused-argument
+        timeout_millis: float = 30_000,
+        **kwargs: Any,
     ) -> None:
         """Shuts down the exporter.
 
@@ -239,7 +239,7 @@ def _ping(self, monitoring_data_point: MonitoringDataPoint) -> Optional[_Respons
                 cls=_Response,
             )
             return ping_response  # type: ignore
-        except Exception:  # pylint: disable=broad-except,invalid-name
+        except Exception:  # pylint: disable=broad-except
             _logger.exception("Exception occurred while pinging live metrics.")
         detach(token)
         return ping_response
@@ -300,7 +300,7 @@ def _ticker(self) -> None:
                                 _set_global_quickpulse_state(_QuickpulseState.PING_LONG)
                             # Reset etag to default if not subscribed
                             _set_quickpulse_etag("")
-                    except Exception:  # pylint: disable=broad-except,invalid-name
+                    except Exception:  # pylint: disable=broad-except
                         _logger.exception("Exception occurred while reading live metrics ping response.")
                         _set_quickpulse_etag("")
                 # TODO: Implement redirect

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_filter.py

@@ -133,7 +133,7 @@ def _check_filters(filters: List[FilterInfo], data: _TelemetryData) -> bool:
         elif name in ("ResultCode", "ResponseCode", "Duration"):
             try:
                 val = int(val)
-            except Exception:  # pylint: disable=broad-exception-caught,invalid-name
+            except Exception:  # pylint: disable=broad-exception-caught
                 return False
             numerical_val = _filter_time_stamp_to_ms(comparand) if name == "Duration" else int(comparand)
             if numerical_val is None:

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_state.py

@@ -96,7 +96,7 @@ def _is_post_state():
 
 
 def _append_quickpulse_document(document: DocumentIngress):
-    # pylint: disable=global-statement,global-variable-not-assigned
+    # pylint: disable=global-variable-not-assigned
     global _QUICKPULSE_DOCUMENTS
     # Limit risk of memory leak by limiting doc length to something manageable
     if len(_QUICKPULSE_DOCUMENTS) > 20:
@@ -143,7 +143,6 @@ def _get_quickpulse_derived_metric_infos() -> Dict[TelemetryType, List[DerivedMe
 
 # Used for initializing and setting projections when span/logs are recorded
 def _set_quickpulse_projection_map(metric_id: str, aggregation_type: AggregationType, value: float, count: int):
-    # pylint: disable=global-statement
     # pylint: disable=global-variable-not-assigned
     global _QUICKPULSE_PROJECTION_MAP
     _QUICKPULSE_PROJECTION_MAP[metric_id] = (aggregation_type, value, count)
@@ -173,7 +172,6 @@ def _reset_quickpulse_projection_map():
 
 # clears the projection map, usually called when config changes
 def _clear_quickpulse_projection_map():
-    # pylint: disable=global-statement
     # pylint: disable=global-variable-not-assigned
     global _QUICKPULSE_PROJECTION_MAP
     _QUICKPULSE_PROJECTION_MAP.clear()

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_utils.py

@@ -174,6 +174,6 @@ def _filter_time_stamp_to_ms(time_stamp: str) -> Optional[int]:
             + float(minutes) * 60 * 1000  # minutes to milliseconds
             + float(seconds) * 1000  # seconds to milliseconds
         )
-    except Exception:  # pylint: disable=broad-except,invalid-name
+    except Exception:  # pylint: disable=broad-except
         pass
     return total_milliseconds

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_quickpulse/_validate.py

@@ -16,7 +16,6 @@
 from azure.monitor.opentelemetry.exporter._quickpulse._utils import _filter_time_stamp_to_ms
 
 
-# pylint: disable=protected-access
 def _validate_derived_metric_info(metric_info: DerivedMetricInfo) -> bool:
     if not _validate_telemetry_type(metric_info.telemetry_type):
         return False
@@ -50,7 +49,7 @@ def _validate_telemetry_type(telemetry_type: str) -> bool:
      # Validate telemetry type
     try:
         telemetry_type = TelemetryType(telemetry_type)
-    except Exception:  # pylint: disable=broad-except,invalid-name
+    except Exception:  # pylint: disable=broad-except
         return False
     # Only REQUEST, DEPENDENCY, EXCEPTION, TRACE are supported
     # No filtering options in UX for PERFORMANCE_COUNTERS
@@ -104,7 +103,7 @@ def _validate_filter_predicate_and_comparand(filter: FilterInfo) -> bool:
     # Validate predicate type
     try:
         predicate = PredicateType(filter.predicate)
-    except Exception:  # pylint: disable=broad-except,invalid-name
+    except Exception:  # pylint: disable=broad-except
         return False
     if not comparand:
         return False
@@ -121,7 +120,7 @@ def _validate_filter_predicate_and_comparand(filter: FilterInfo) -> bool:
             try:
                 # Response/ResultCode comparand should be interpreted as integer
                 int(comparand)
-            except Exception:  # pylint: disable=broad-except,invalid-name
+            except Exception:  # pylint: disable=broad-except
                 return False
     elif name == "Success":
         if predicate not in (PredicateType.EQUAL, PredicateType.NOT_EQUAL):

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_storage.py

@@ -113,7 +113,6 @@ def __enter__(self):
     def __exit__(self, type, value, traceback):
         self.close()
 
-    # pylint: disable=unused-variable
     def _maintenance_routine(self):
         try:
             # pylint: disable=unused-variable

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py

@@ -181,7 +181,6 @@ def _handle_transmit_from_storage(self, envelopes: List[TelemetryItem], result:
 
     # pylint: disable=too-many-branches
     # pylint: disable=too-many-nested-blocks
-    # pylint: disable=too-many-return-statements
     # pylint: disable=too-many-statements
     def _transmit(self, envelopes: List[TelemetryItem]) -> ExportResult:
         """
@@ -256,7 +255,7 @@ def _transmit(self, envelopes: List[TelemetryItem]) -> ExportResult:
                             url = urlparse(location)
                         else:
                             redirect_has_headers = False
-                        if redirect_has_headers and url.scheme and url.netloc:
+                        if redirect_has_headers and url.scheme and url.netloc:  # pylint: disable=E0606
                             # Change the host to the new redirected host
                             self.client._config.host = "{}://{}".format(url.scheme, url.netloc)  # pylint: disable=W0212
                             # Attempt to export again
@@ -333,9 +332,9 @@ def _transmit(self, envelopes: List[TelemetryItem]) -> ExportResult:
 
                             shutdown_statsbeat_metrics()
                             # pylint: disable=lost-exception
-                            return ExportResult.FAILED_NOT_RETRYABLE  # pylint: disable=W0012,W0134
+                            return ExportResult.FAILED_NOT_RETRYABLE  # pylint: disable=W0134
                 # pylint: disable=lost-exception
-                return result  # pylint: disable=W0012,W0134
+                return result  # pylint: disable=W0134
 
         # No spans to export
         self._consecutive_redirects = 0

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/logs/_exporter.py

@@ -130,7 +130,6 @@ def _convert_log_to_envelope(log_data: LogData) -> TelemetryItem:
     if log_record.attributes:
         exc_type = log_record.attributes.get(EXCEPTION_TYPE)
         exc_message = log_record.attributes.get(EXCEPTION_MESSAGE)
-        # pylint: disable=line-too-long
         stack_trace = log_record.attributes.get(EXCEPTION_STACKTRACE)
     severity_level = _get_severity_level(log_record.severity_number)
 
@@ -167,7 +166,6 @@ def _convert_log_to_envelope(log_data: LogData) -> TelemetryItem:
             properties=properties,
             exceptions=[exc_details],
         )
-        # pylint: disable=line-too-long
         envelope.data = MonitorBase(base_data=data, base_type="ExceptionData")
     else:  # Message telemetry
         envelope.name = _MESSAGE_ENVELOPE_NAME

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/metrics/_exporter.py

@@ -73,8 +73,8 @@ def __init__(self, **kwargs: Any) -> None:
     def export(
         self,
         metrics_data: OTMetricsData,
-        timeout_millis: float = 10_000,  # pylint: disable=unused-argument
-        **kwargs: Any,  # pylint: disable=unused-argument
+        timeout_millis: float = 10_000,
+        **kwargs: Any,
     ) -> MetricExportResult:
         """Exports a batch of metric data
 
@@ -119,8 +119,8 @@ def force_flush(
 
     def shutdown(
         self,
-        timeout_millis: float = 30_000,  # pylint: disable=unused-argument
-        **kwargs: Any,  # pylint: disable=unused-argument
+        timeout_millis: float = 30_000,
+        **kwargs: Any,
     ) -> None:
         """Shuts down the exporter.
 
@@ -212,7 +212,6 @@ def _convert_point_to_envelope(
     return envelope
 
 
-# pylint: disable=protected-access
 def _handle_std_metric_envelope(
     envelope: TelemetryItem,
     name: str,

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_exporter.py

@@ -177,7 +177,6 @@ def from_connection_string(cls, conn_str: str, **kwargs: Any) -> "AzureMonitorTr
 
 # pylint: disable=too-many-statements
 # pylint: disable=too-many-branches
-# pylint: disable=too-many-locals
 # pylint: disable=protected-access
 # mypy: disable-error-code="assignment,attr-defined,index,operator,union-attr"
 def _convert_span_to_envelope(span: ReadableSpan) -> TelemetryItem:
@@ -196,7 +195,6 @@ def _convert_span_to_envelope(span: ReadableSpan) -> TelemetryItem:
         envelope.tags[ContextTagKeys.AI_USER_ID] = span.attributes[SpanAttributes.ENDUSER_ID]
     if span.parent and span.parent.span_id:
         envelope.tags[ContextTagKeys.AI_OPERATION_PARENT_ID] = "{:016x}".format(span.parent.span_id)
-    # pylint: disable=too-many-nested-blocks
     if span.kind in (SpanKind.CONSUMER, SpanKind.SERVER):
         envelope.name = _REQUEST_ENVELOPE_NAME
         data = RequestData(
@@ -482,7 +480,6 @@ def _convert_span_events_to_envelopes(span: ReadableSpan) -> Sequence[TelemetryI
                 properties=properties,
                 exceptions=[exc_details],
             )
-            # pylint: disable=line-too-long
             envelope.data = MonitorBase(base_data=data, base_type="ExceptionData")
         else:
             envelope.name = _MESSAGE_ENVELOPE_NAME

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/trace/_sampling.py

@@ -5,7 +5,6 @@
 # pylint:disable=no-name-in-module
 from fixedint import Int32
 
-# pylint:disable=W0611
 from opentelemetry.context import Context
 from opentelemetry.trace import Link, SpanKind, format_trace_id
 from opentelemetry.sdk.trace.sampling import (

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/statsbeat/_exporter.py

@@ -12,7 +12,6 @@
 
 class _StatsBeatExporter(AzureMonitorMetricExporter):
 
-    # pylint: disable=protected-access
     def _point_to_envelope(
         self,
         point: DataPointT,

sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/statsbeat/_statsbeat_metrics.py

@@ -230,7 +230,6 @@ def _get_azure_compute_metadata(self) -> bool:
         return True
 
     # pylint: disable=unused-argument
-    # pylint: disable=protected-access
     def _get_feature_metric(self, options: CallbackOptions) -> Iterable[Observation]:
         observations: List[Observation] = []
         # Check if it is time to observe long interval metrics
@@ -314,7 +313,6 @@ def init_non_initial_metrics(self):
         )
 
     # pylint: disable=unused-argument
-    # pylint: disable=protected-access
     def _get_success_count(self, options: CallbackOptions) -> Iterable[Observation]:
         # get_success_count is special in such that it is the indicator of when
         # a short interval collection has happened, which is why we increment
@@ -335,7 +333,6 @@ def _get_success_count(self, options: CallbackOptions) -> Iterable[Observation]:
         return observations
 
     # pylint: disable=unused-argument
-    # pylint: disable=protected-access
     def _get_failure_count(self, options: CallbackOptions) -> Iterable[Observation]:
         observations = []
         attributes = dict(_StatsbeatMetrics._COMMON_ATTRIBUTES)
@@ -350,7 +347,6 @@ def _get_failure_count(self, options: CallbackOptions) -> Iterable[Observation]:
         return observations
 
     # pylint: disable=unused-argument
-    # pylint: disable=protected-access
     def _get_average_duration(self, options: CallbackOptions) -> Iterable[Observation]:
         observations = []
         attributes = dict(_StatsbeatMetrics._COMMON_ATTRIBUTES)
@@ -367,7 +363,6 @@ def _get_average_duration(self, options: CallbackOptions) -> Iterable[Observatio
         return observations
 
     # pylint: disable=unused-argument
-    # pylint: disable=protected-access
     def _get_retry_count(self, options: CallbackOptions) -> Iterable[Observation]:
         observations = []
         attributes = dict(_StatsbeatMetrics._COMMON_ATTRIBUTES)
@@ -382,7 +377,6 @@ def _get_retry_count(self, options: CallbackOptions) -> Iterable[Observation]:
         return observations
 
     # pylint: disable=unused-argument
-    # pylint: disable=protected-access
     def _get_throttle_count(self, options: CallbackOptions) -> Iterable[Observation]:
         observations = []
         attributes = dict(_StatsbeatMetrics._COMMON_ATTRIBUTES)
@@ -397,7 +391,6 @@ def _get_throttle_count(self, options: CallbackOptions) -> Iterable[Observation]
         return observations
 
     # pylint: disable=unused-argument
-    # pylint: disable=protected-access
     def _get_exception_count(self, options: CallbackOptions) -> Iterable[Observation]:
         observations = []
         attributes = dict(_StatsbeatMetrics._COMMON_ATTRIBUTES)

sdk/monitor/azure-monitor-opentelemetry-exporter/samples/traces/django/sample/manage.py

@@ -26,7 +26,7 @@ def main():
     span_processor = BatchSpanProcessor(
         AzureMonitorTraceExporter.from_connection_string(os.environ["APPLICATIONINSIGHTS_CONNECTION_STRING"])
     )
-    trace.get_tracer_provider().add_span_processor(span_processor)
+    trace.get_tracer_provider().add_span_processor(span_processor)  # type: ignore
 
     try:
         from django.core.management import execute_from_command_line

sdk/monitor/azure-monitor-opentelemetry-exporter/samples/traces/django/sample/sample/asgi.py

@@ -31,7 +31,7 @@
 span_processor = BatchSpanProcessor(
     AzureMonitorTraceExporter.from_connection_string(os.environ["APPLICATIONINSIGHTS_CONNECTION_STRING"])
 )
-trace.get_tracer_provider().add_span_processor(span_processor)
+trace.get_tracer_provider().add_span_processor(span_processor)  # type: ignore
 
 application = get_asgi_application()
 

sdk/monitor/azure-monitor-opentelemetry-exporter/samples/traces/django/sample/sample/wsgi.py

@@ -30,6 +30,6 @@
 span_processor = BatchSpanProcessor(
     AzureMonitorTraceExporter.from_connection_string(os.environ["APPLICATIONINSIGHTS_CONNECTION_STRING"])
 )
-trace.get_tracer_provider().add_span_processor(span_processor)
+trace.get_tracer_provider().add_span_processor(span_processor)  # type: ignore
 
 application = get_wsgi_application()