Skip to content

Proxies broken in .NET Core 3.0 #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brettsam opened this issue Aug 7, 2019 · 1 comment
Closed

Proxies broken in .NET Core 3.0 #4770

brettsam opened this issue Aug 7, 2019 · 1 comment
Labels

Comments

@brettsam
Copy link
Member

brettsam commented Aug 7, 2019

My analysis from an internal investigation (this is mostly a Teams transcript that I've cleaned up)

We end up with read-only headers when we try to set them in proxies -- this behavior is new in ASP.NET Core 3.0.

This PR changed it: dotnet/aspnetcore#7110. Specifically -- https://github.com/aspnet/AspNetCore/pull/7110/files#diff-6f529bca1b5cb1bf98dbd8b32d27969d.

Notice that right there it now calls response.StartAsync() -- that didn't use to happen; it just wrote the body.

The summary:
Once we call the localFunctionResult, the response is started and headers are marked as read-only. This is new in .NET Core 3: link to location in internal repo.

so when we go to run the proxyResult -- the headers are locked and it throws: link to location in internal repo.

@brettsam brettsam added the 3.x label Aug 7, 2019
@brettsam brettsam added this to the Triaged milestone Aug 7, 2019
@brettsam
Copy link
Member Author

Proxies was fixed and we've taken the fix with #5050

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant