Add type hints to gradualkiller, grudger, grumpy (#856)

* Add type hints to gradualkiller

* Add type hints to grudger

* Add type hints to grumpy

* Add files to type_tests

Author: janga1997

axelrod/strategies/gradualkiller.py

@@ -1,5 +1,6 @@
 from axelrod import Actions, Player
 from axelrod.strategy_transformers import InitialTransformer
+from axelrod.actions import Action
 
 C, D = Actions.C, Actions.D
 
@@ -30,7 +31,7 @@ class GradualKiller(Player):
         'manipulates_state': False
     }
 
-    def strategy(self, opponent):
+    def strategy(self, opponent: Player) -> Action:
         if opponent.history[5:7] == [D, D]:
             return D
         return C

axelrod/strategies/grudger.py

@@ -1,4 +1,5 @@
 from axelrod import Actions, Player
+from axelrod.actions import Action
 
 C, D = Actions.C, Actions.D
 
@@ -29,7 +30,7 @@ class Grudger(Player):
     }
 
     @staticmethod
-    def strategy(opponent):
+    def strategy(opponent: Player) -> Action:
         """Begins by playing C, then plays D for the remaining rounds if the
         opponent ever plays D."""
         if opponent.defections:
@@ -52,14 +53,14 @@ class ForgetfulGrudger(Player):
         'manipulates_state': False
     }
 
-    def __init__(self):
+    def __init__(self) -> None:
         """Initialised the player."""
         super().__init__()
         self.mem_length = 10
         self.grudged = False
         self.grudge_memory = 0
 
-    def strategy(self, opponent):
+    def strategy(self, opponent: Player) -> Action:
         """Begins by playing C, then plays D for mem_length rounds if the
         opponent ever plays D."""
         if self.grudge_memory >= self.mem_length:
@@ -97,7 +98,7 @@ class OppositeGrudger(Player):
     }
 
     @staticmethod
-    def strategy(opponent):
+    def strategy(opponent: Player) -> Action:
         """Begins by playing D, then plays C for the remaining rounds if the
         opponent ever plays C."""
         if opponent.cooperations:
@@ -120,7 +121,7 @@ class Aggravater(Player):
     }
 
     @staticmethod
-    def strategy(opponent):
+    def strategy(opponent: Player) -> Action:
         if len(opponent.history) < 3:
             return D
         elif opponent.defections:
@@ -151,13 +152,13 @@ class SoftGrudger(Player):
         'manipulates_state': False
     }
 
-    def __init__(self):
+    def __init__(self) -> None:
         """Initialised the player."""
         super().__init__()
         self.grudged = False
         self.grudge_memory = 0
 
-    def strategy(self, opponent):
+    def strategy(self, opponent: Player) -> Action:
         """Begins by playing C, then plays D, D, D, D, C, C against a defection
         """
         if self.grudged:
@@ -201,7 +202,7 @@ class GrudgerAlternator(Player):
         'manipulates_state': False
     }
 
-    def strategy(self, opponent):
+    def strategy(self, opponent: Player) -> Action:
         """Begins by playing C, then plays Alternator for the remaining rounds
         if the opponent ever plays D."""
         if opponent.defections:
@@ -232,7 +233,7 @@ class EasyGo(Player):
     }
 
     @staticmethod
-    def strategy(opponent):
+    def strategy(opponent: Player) -> Action:
         """Begins by playing D, then plays C for the remaining rounds if the
         opponent ever plays D."""
         if opponent.defections:

axelrod/strategies/grumpy.py

@@ -1,4 +1,5 @@
 from axelrod import Actions, Player
+from axelrod.actions import Action
 
 C, D = Actions.C, Actions.D
 
@@ -19,8 +20,8 @@ class Grumpy(Player):
         'manipulates_state': False
     }
 
-    def __init__(self, starting_state='Nice', grumpy_threshold=10,
-                 nice_threshold=-10):
+    def __init__(self, starting_state: str ='Nice', grumpy_threshold: int =10,
+                 nice_threshold: int =-10) -> None:
         """
         Parameters
         ----------
@@ -38,7 +39,7 @@ def __init__(self, starting_state='Nice', grumpy_threshold=10,
         self.grumpy_threshold = grumpy_threshold
         self.nice_threshold = nice_threshold
 
-    def strategy(self, opponent):
+    def strategy(self, opponent: Player) -> Action:
         """A player that gets grumpier the more the opposition defects,
         and nicer the more they cooperate.
 

type_tests.sh

@@ -19,3 +19,6 @@ mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/cooperato
 mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/axelrod_second.py
 mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/backstabber.py
 mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/defector.py
+mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/gradualkiller.py
+mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/grudger.py
+mypy --ignore-missing-imports --follow-imports skip axelrod/strategies/grumpy.py